From: Vincent Davis Jr <vince@underview.tech>
To: openembedded-core@lists.openembedded.org
Cc: Vincent Davis Jr <vince@underview.tech>
Subject: [PATCH v8 7/9] bootimg_pcbios: include grub as an optional bootloader
Date: Thu, 14 Aug 2025 00:25:50 -0400 [thread overview]
Message-ID: <20250814042552.21887-7-vince@underview.tech> (raw)
In-Reply-To: <20250814042552.21887-1-vince@underview.tech>
Commit adds in support for installation of both
grub and syslinux using newly added grub functions.
Due to the bootimg_biosplusefi source_params['loader']
had to be named source_params['loader-bios'] so not
to create conflict in the wics plugin.
Commits also adds ability to set and or not set
source_params. If source_params set check
for both
* syslinux
* grub
if not set default to using syslinux as bootloader.
Signed-off-by: Vincent Davis Jr <vince@underview.tech>
---
.../lib/wic/plugins/source/bootimg_pcbios.py | 42 ++++++++++++++++---
1 file changed, 36 insertions(+), 6 deletions(-)
diff --git a/scripts/lib/wic/plugins/source/bootimg_pcbios.py b/scripts/lib/wic/plugins/source/bootimg_pcbios.py
index f50a5ae0e2..1fa9d895bb 100644
--- a/scripts/lib/wic/plugins/source/bootimg_pcbios.py
+++ b/scripts/lib/wic/plugins/source/bootimg_pcbios.py
@@ -31,6 +31,9 @@ class BootimgPcbiosPlugin(SourcePlugin):
name = 'bootimg_pcbios'
+ # Variable required for do_install_disk
+ loader = ''
+
@classmethod
def _get_bootimg_dir(cls, bootimg_dir, dirname):
"""
@@ -56,23 +59,50 @@ class BootimgPcbiosPlugin(SourcePlugin):
logger.debug("Installing MBR on disk %s as %s with size %s bytes",
disk_name, full_path, disk.min_size)
- cls._do_install_syslinux(creator, bootimg_dir,
+ if cls.loader == 'grub':
+ cls._do_install_grub(creator, kernel_dir,
+ native_sysroot, full_path)
+ elif cls.loader == 'syslinux':
+ cls._do_install_syslinux(creator, bootimg_dir,
native_sysroot, full_path)
+ else:
+ raise WicError("boot loader some how not specified check do_prepare_partition")
@classmethod
def do_configure_partition(cls, part, source_params, creator, cr_workdir,
oe_builddir, bootimg_dir, kernel_dir,
native_sysroot):
-
- cls._do_configure_syslinux(part, creator, cr_workdir)
+ try:
+ if source_params['loader-bios'] == 'grub':
+ cls._do_configure_grub(part, creator, cr_workdir)
+ elif source_params['loader-bios'] == 'syslinux':
+ cls._do_configure_syslinux(part, creator, cr_workdir)
+ else:
+ raise WicError("unrecognized bootimg_pcbios loader: %s" % source_params['loader-bios'])
+ except KeyError:
+ cls._do_configure_syslinux(part, creator, cr_workdir)
@classmethod
def do_prepare_partition(cls, part, source_params, creator, cr_workdir,
oe_builddir, bootimg_dir, kernel_dir,
rootfs_dir, native_sysroot):
-
- cls._do_prepare_syslinux(part, cr_workdir, bootimg_dir,
- kernel_dir, native_sysroot)
+ try:
+ if source_params['loader-bios'] == 'grub':
+ cls._do_prepare_grub(part, cr_workdir, oe_builddir,
+ kernel_dir, rootfs_dir, native_sysroot)
+ elif source_params['loader-bios'] == 'syslinux':
+ cls._do_prepare_syslinux(part, cr_workdir, bootimg_dir,
+ kernel_dir, native_sysroot)
+ else:
+ raise WicError("unrecognized bootimg_pcbios loader: %s" % source_params['loader-bios'])
+
+ # Required by do_install_disk
+ cls.loader = source_params['loader-bios']
+ except KeyError:
+ # Required by do_install_disk
+ cls.loader = 'syslinux'
+ cls._do_prepare_syslinux(part, cr_workdir, bootimg_dir,
+ kernel_dir, native_sysroot)
@classmethod
def _get_staging_libdir(cls):
--
2.34.1
next prev parent reply other threads:[~2025-08-14 4:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 4:25 [PATCH v8 1/9] bootimg_pcbios: move syslinux install into seperate functions Vincent Davis Jr
2025-08-14 4:25 ` [PATCH v8 2/9] bootimg_pcbios: move syslinux funcs to end of file Vincent Davis Jr
2025-08-14 4:25 ` [PATCH v8 3/9] bootimg_pcbios: seperate bootloader config creation Vincent Davis Jr
2025-08-14 4:25 ` [PATCH v8 4/9] bootimg_pcbios: cleanup _do_configure_syslinux function Vincent Davis Jr
2025-08-14 4:25 ` [PATCH v8 5/9] bootimg_pcbios: cleanup prepare and install syslinux funcs Vincent Davis Jr
2025-08-14 4:25 ` [PATCH v8 6/9] bootimg_pcbios: add funcs to configure booting with grub Vincent Davis Jr
2025-08-14 4:25 ` Vincent Davis Jr [this message]
2025-08-14 4:25 ` [PATCH v8 8/9] bootimg_pcbios: add help and usage comments Vincent Davis Jr
2025-08-14 4:25 ` [PATCH v8 9/9] oe-selftest: add wic.Wic.test_grub_install_pcbios Vincent Davis Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814042552.21887-7-vince@underview.tech \
--to=vince@underview.tech \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox