public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: dani.barra25@gmail.com
To: openembedded-core@lists.openembedded.org,
	mathieu.dubois-briand@bootlin.com
Subject: Re: [OE-core] [PATCH 1/1] wic: Content of the temporary updated fstab should be copied into the original not replacing it entirely.
Date: Fri, 17 Oct 2025 12:04:15 +0100	[thread overview]
Message-ID: <20251017111210.501333-1-dani.barra25@gmail.com> (raw)
In-Reply-To: <DDFITTM4J8SO.13FKL48ZAQCD0@bootlin.com>


Hi Mathieu,

Thank you for the you time testing this thoroughly.
After some test, I was able to provide a new alternative (attached to this message if everything goes well).

For the performance part of ext* and msdos fstype I have nothing to counter argument. I did not find a way to add xattrs using those methods and, according to what seemed to be the natural way of
the code design of wic, I let all the fstype flal under rootfs.py.  Any other solution is welcome!

For the second part, this time, instead of using cp, I let the install be like it was before. However, instead of running it under the pseudo environment, I executed it as the host machine.
This way, I was able to recheck the database using pseudo, which will fail and therefore led the files.db to be rebuilt. This happens because he is able to detect the inodes of fstab entry on all
the tables do not match and update them accordingly. This way we don't run the risk of modifying the original content of fstab under the normal yocto output files because the file is actually not the same.

I also ran oe-selftest -r wic.Wic.test_no_fstab_update on a core-image-minimal image with the patch and it seemed to have passed.

Best Regards,
Daniel


  reply	other threads:[~2025-10-17 11:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 19:05 [PATCH 0/1] wic: updated fstab does not preserve metadata of the original file dani.barra25
2025-09-02 19:05 ` [PATCH 1/1] wic: Content of the temporary updated fstab should be copied into the original not replacing it entirely dani.barra25
2025-10-11 13:18   ` [OE-core] " Mathieu Dubois-Briand
2025-10-17 11:04     ` dani.barra25 [this message]
2025-10-17 11:04       ` [PATCH 1/1] Fstab: Fix xattrs not being maintained on fstab file when using wic fstab update funtionalities dani.barra25
2025-10-19 10:02         ` Mathieu Dubois-Briand
     [not found]           ` <20251019153922.27208-1-dani.barra25@gmail.com>
2025-10-19 15:39             ` [PATCH] Fstab xattrs: This update ensures that fstab xattrs are correctly updated without adding a lock to the database dani.barra25
2025-10-20 12:09               ` [OE-core] " Alexander Kanavin
2025-10-20 13:18                 ` Daniel Andrade
2025-10-23 13:04                 ` Ross Burton
2025-10-19 15:41           ` [PATCH 1/1] Fstab: Fix xattrs not being maintained on fstab file when using wic fstab update funtionalities Daniel Andrade
2025-09-04 15:58 ` [OE-core] [PATCH 0/1] wic: updated fstab does not preserve metadata of the original file Mathieu Dubois-Briand
2025-09-11 16:56   ` Randy MacLeod
2025-09-13 10:02     ` Daniel Andrade
2025-09-23 15:05       ` Daniel Andrade
2025-09-23 18:44         ` Mathieu Dubois-Briand
2025-09-24 16:04           ` Daniel Andrade
2025-09-25  8:57             ` Mathieu Dubois-Briand
2025-09-25 11:11               ` Mathieu Dubois-Briand
2025-09-25 11:40                 ` Daniel Andrade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251017111210.501333-1-dani.barra25@gmail.com \
    --to=dani.barra25@gmail.com \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox