Re: [OE-core] [scarthgap][PATCH] oeqa/runtime/ping: don't bother trying to ping localhost

[Denys Dmytriyenko <denis@denix.org>]

On Wed, Oct 15, 2025 at 10:41:31PM +0200, Michael Haener via lists.openembedded.org wrote:
> If SLIRP is being used instead of TAP for networking to the guest then
> the target IP will be localhost.  There's no point in pinging localhost
> to see if the target is up but whilst you'd think it is harmless, in
> some containers ping doesn't actually have enough rights to work:
> 
>   ping: socktype: SOCK_RAW
>   ping: socket: Operation not permitted
>   ping: => missing cap_net_raw+p capability or setuid?
> 
> Look at the target address and if it's localhost or 127.0.0.* return
> immediately.
> 
> (Backport from OE-Core rev: a06ef43d2a50e16c32bd6edbdc7b32c3528687d5)
> 
> Signed-off-by: Michael Haener <michael.haener@siemens.com>
> ---
>  meta/lib/oeqa/runtime/cases/ping.py | 7 +++++++
>  test                                | 0
>  2 files changed, 7 insertions(+)
>  create mode 100644 test
> 
> diff --git a/meta/lib/oeqa/runtime/cases/ping.py b/meta/lib/oeqa/runtime/cases/ping.py
> index f72460e7f3..bc543f6c41 100644
> --- a/meta/lib/oeqa/runtime/cases/ping.py
> +++ b/meta/lib/oeqa/runtime/cases/ping.py
> @@ -18,6 +18,13 @@ class PingTest(OERuntimeTestCase):
>          output = ''
>          count = 0
>          self.assertNotEqual(len(self.target.ip), 0, msg="No target IP address set")
> +
> +        # If the target IP is localhost (because user-space networking is being used),
> +        # then there's no point in pinging it.
> +        if self.target.ip.startswith("127.0.0.") or self.target.ip in ("localhost", "::1"):
> +            print("runtime/ping: localhost detected, not pinging")
> +            return
> +
>          try:
>              while count < 5:
>                  cmd = 'ping -c 1 %s' % self.target.ip
> diff --git a/test b/test
> new file mode 100644
> index 0000000000..e69de29bb2

Should there be an empty "test" file in the root directory of OE-Core?

-- 
Denys