public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Qi.Chen@windriver.com
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][PATCH 1/2] systemd: do not let do_fetch depend on PACKAGECONFIG
Date: Thu, 15 Jan 2026 10:19:17 +0800	[thread overview]
Message-ID: <20260115021918.1926514-1-Qi.Chen@windriver.com> (raw)

From: Chen Qi <Qi.Chen@windriver.com>

It's unnecessary to make SRC_URI contains something like:
${@bb.utils.contains('PACKAGECONFIG', 'xxx', 'file://xxx', '', d)}
This does not give us any benefit and it makes do_fetch depend
on PACKAGECONFIG, which means changing of PACKAGECONFIG will result
in rerunn of do_fetch.

Besides, the related codes in do_install already does the necessary
checks.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-core/systemd/systemd_258.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/systemd/systemd_258.1.bb b/meta/recipes-core/systemd/systemd_258.1.bb
index 410396f308..41f1e756cb 100644
--- a/meta/recipes-core/systemd/systemd_258.1.bb
+++ b/meta/recipes-core/systemd/systemd_258.1.bb
@@ -21,8 +21,8 @@ REQUIRED_DISTRO_FEATURES += "systemd"
 SRC_URI += " \
            file://touchscreen.rules \
            file://00-create-volatile.conf \
-           ${@bb.utils.contains('PACKAGECONFIG', 'polkit_hostnamed_fallback', 'file://org.freedesktop.hostname1_no_polkit.conf', '', d)} \
-           ${@bb.utils.contains('PACKAGECONFIG', 'polkit_hostnamed_fallback', 'file://00-hostnamed-network-user.conf', '', d)} \
+           file://org.freedesktop.hostname1_no_polkit.conf \
+           file://00-hostnamed-network-user.conf \
            file://init \
            file://99-default.preset \
            file://systemd-pager.sh \
-- 
2.34.1



             reply	other threads:[~2026-01-15  2:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15  2:19 Qi.Chen [this message]
2026-01-15  2:19 ` [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG Qi.Chen
2026-01-23 13:06   ` Paul Barker
2026-01-28  2:47     ` ChenQi
2026-04-05 14:04       ` [PATCH " Martin Siegumfeldt
2026-01-26 12:54   ` [OE-core][PATCH " Ross Burton
2026-01-27  9:09     ` Chen, Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115021918.1926514-1-Qi.Chen@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox