From: Ross Burton <ross.burton@arm.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 6/8] pkgconf: small cleanups
Date: Fri, 23 Jan 2026 18:04:46 +0000 [thread overview]
Message-ID: <20260123180448.2997378-7-ross.burton@arm.com> (raw)
In-Reply-To: <20260123180448.2997378-1-ross.burton@arm.com>
There's no need to --with-pkg-confg-dir as the default is the same and
correct.
Don't append BBCLASSEXTEND, there's no need.
Sync pkg-config-native with the pkg-config recipe so that it sets
the variables in the same way.
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
meta/recipes-devtools/pkgconf/pkgconf/pkg-config-native.in | 3 ++-
meta/recipes-devtools/pkgconf/pkgconf_2.5.1.bb | 5 ++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-devtools/pkgconf/pkgconf/pkg-config-native.in b/meta/recipes-devtools/pkgconf/pkgconf/pkg-config-native.in
index 0d736fe4d4..8addefbb80 100644
--- a/meta/recipes-devtools/pkgconf/pkgconf/pkg-config-native.in
+++ b/meta/recipes-devtools/pkgconf/pkgconf/pkg-config-native.in
@@ -1,6 +1,7 @@
#! /bin/sh
-PKG_CONFIG_PATH="@PATH_NATIVE@$EXTRA_NATIVE_PKGCONFIG_PATH"
+export PKG_CONFIG_PATH="@PATH_NATIVE@$EXTRA_NATIVE_PKGCONFIG_PATH"
+export PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
unset PKG_CONFIG_SYSROOT_DIR
pkg-config "$@"
diff --git a/meta/recipes-devtools/pkgconf/pkgconf_2.5.1.bb b/meta/recipes-devtools/pkgconf/pkgconf_2.5.1.bb
index 12ca075b5d..e3500431b3 100644
--- a/meta/recipes-devtools/pkgconf/pkgconf_2.5.1.bb
+++ b/meta/recipes-devtools/pkgconf/pkgconf_2.5.1.bb
@@ -24,8 +24,6 @@ SRC_URI[sha256sum] = "cd05c9589b9f86ecf044c10a2269822bc9eb001eced2582cfffd658b0a
inherit autotools
-EXTRA_OECONF += "--with-pkg-config-dir='${libdir}/pkgconfig:${datadir}/pkgconfig'"
-
do_install:append () {
# Install a wrapper which deals, as much as possible with pkgconf vs
# pkg-config compatibility issues.
@@ -36,6 +34,7 @@ do_install:append:class-native () {
# Install a pkg-config-native wrapper that will use the native sysroot instead
# of the MACHINE sysroot, for using pkg-config when building native tools.
sed -e "s|@PATH_NATIVE@|${PKG_CONFIG_PATH}|" \
+ -e "s|@LIBDIR_NATIVE@|${PKG_CONFIG_LIBDIR}|" \
< ${UNPACKDIR}/pkg-config-native.in > ${B}/pkg-config-native
install -m755 ${B}/pkg-config-native ${D}${bindir}/pkg-config-native
sed -e "s|@PATH_NATIVE@|${PKG_CONFIG_PATH}|" \
@@ -53,7 +52,7 @@ RPROVIDES:${PN} += "pkgconfig(pkg-config)"
FILES:${PN}-dev:remove = "${datadir}/aclocal"
FILES:${PN} += "${datadir}/aclocal"
-BBCLASSEXTEND += "native nativesdk"
+BBCLASSEXTEND = "native nativesdk"
pkgconf_sstate_fixup_esdk () {
if [ "${BB_CURRENTTASK}" = "populate_sysroot_setscene" -a "${WITHIN_EXT_SDK}" = "1" ] ; then
--
2.43.0
next prev parent reply other threads:[~2026-01-23 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 18:04 [PATCH 0/8] Rationalise the pkg-config variables Ross Burton
2026-01-23 18:04 ` [PATCH 1/8] pkgconfig: inherit the pkgconfig class Ross Burton
2026-01-23 18:04 ` [PATCH 2/8] perf: " Ross Burton
2026-01-23 18:04 ` [PATCH 3/8] python3-numpy: backport a Meson patch to fix pkg-config lookups Ross Burton
2026-01-23 18:04 ` [PATCH 4/8] classes/pkgconfig: move variable exports to the class Ross Burton
2026-01-23 18:04 ` [PATCH 5/8] classes/pkgconfig: rationalise variable usage Ross Burton
2026-01-28 13:30 ` [OE-core] " Mathieu Dubois-Briand
2026-01-29 6:17 ` Mathieu Dubois-Briand
2026-02-06 10:29 ` Ross Burton
2026-01-23 18:04 ` Ross Burton [this message]
2026-01-23 18:04 ` [PATCH 7/8] pkgconf: add pkg-config-native to the nativesdk package Ross Burton
2026-01-23 18:04 ` [PATCH 8/8] kernel: remove pkg-config variables for old (<5.15) kernels Ross Burton
2026-01-23 18:07 ` [OE-core] [PATCH 0/8] Rationalise the pkg-config variables Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123180448.2997378-7-ross.burton@arm.com \
--to=ross.burton@arm.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox