public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Logan Gallois <logan.gallois@gmail.com>
To: logan.gallois@gmail.com
Cc: logan.gallois@hexagon.com,
	openembedded-core@lists.openembedded.org,
	patchtest@automation.yoctoproject.org
Subject: [OE-Core][whinlatter][PATCH v5] oe-setup-build: TEMPLATECONF were not applied correctly
Date: Tue, 10 Feb 2026 18:44:34 +0100	[thread overview]
Message-ID: <20260210174434.4992-1-logan.gallois@gmail.com> (raw)
In-Reply-To: <20260209233345.3742-1-logan.gallois@gmail.com>

Since a recent change to support dash, cmd_base is a set of several
commands, separated by newlines.
TEMPLATECONF was only effective for the first command in that set,
which is not where it's needed.
Putting it on its own line will ensure that it's present for
everything in cmd_base.

Signed-off-by: Logan Gallois <logan.gallois@hexagon.com>
---
 scripts/oe-setup-build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/oe-setup-build b/scripts/oe-setup-build
index edbcd48355a..7bcdeee4c32 100755
--- a/scripts/oe-setup-build
+++ b/scripts/oe-setup-build
@@ -98,7 +98,7 @@ def setup_build_env(args):
             f.write(cmd_base)
     print("\nRun '. {}' to initialize the build in a current shell session.\n".format(initbuild))
 
-    cmd = "TEMPLATECONF={} {}".format(template["templatepath"], cmd_base)
+    cmd = "TEMPLATECONF={}\n{}".format(template["templatepath"], cmd_base)
     if not no_shell:
         cmd = cmd + " && {}".format(os.environ.get('SHELL','bash'))
     print("Running:", cmd)
-- 
2.43.0



  reply	other threads:[~2026-02-10 17:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-08 14:40 [OE-Core][whinlatter][PATCH] oe-setup-build: fix TEMPLATECONF not being applied Logan Gallois
2026-02-09 23:03 ` [OE-Core][whinlatter][PATCH v2] oe-setup-build: TEMPLATECONF were not applied correctly Logan Gallois
2026-02-09 23:15   ` Patchtest results for " patchtest
2026-02-09 23:33     ` [OE-Core][whinlatter][PATCH v4] " Logan Gallois
2026-02-10 17:44       ` Logan Gallois [this message]
2026-02-09 23:07 ` [OE-Core][whinlatter][PATCH v3] " Logan Gallois
2026-02-09 23:15   ` Patchtest results for " patchtest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260210174434.4992-1-logan.gallois@gmail.com \
    --to=logan.gallois@gmail.com \
    --cc=logan.gallois@hexagon.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=patchtest@automation.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox