[PATCH] externalsrc: fix duplicate entries in .git/info/exclude

[PATCH] externalsrc: fix duplicate entries in .git/info/exclude

[Aditya Kurdunkar]

`readlines()` preserves trailing newlines, so the duplicate check
against the stripped link name never matched. Strip lines before
comparing to prevent repeated entries on each devtool modify run.

Signed-off-by: Aditya Kurdunkar <adityakurdunkar2@gmail.com>
---
 meta/classes/externalsrc.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
index 527c99ab69..902ff2604f 100644
--- a/meta/classes/externalsrc.bbclass
+++ b/meta/classes/externalsrc.bbclass
@@ -188,7 +188,7 @@ python externalsrc_configure_prefunc() {
             git_exclude_file = os.path.join(git_dir, 'info/exclude')
             if os.path.exists(git_exclude_file):
                 with open(git_exclude_file, 'r+') as efile:
-                    elines = efile.readlines()
+                    elines = [line.strip() for line in efile]
                     for link in newlinks:
                         if link in elines or '/'+link in elines:
                             continue
-- 
2.43.0

Re: [PATCH] externalsrc: fix duplicate entries in .git/info/exclude

[Aditya Kurdunkar]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

Hi everyone,
I’m new to contributing to the OpenEmbedded project. Could someone please let me know the process for getting this patch reviewed?

[-- Attachment #2: Type: text/html, Size: 199 bytes --]

Re: [OE-core] [PATCH] externalsrc: fix duplicate entries in .git/info/exclude

[Mathieu Dubois-Briand]

On Mon Mar 16, 2026 at 4:31 AM CET, Aditya Kurdunkar via lists.openembedded.org wrote:
> Hi everyone,
> I’m new to contributing to the OpenEmbedded project. Could someone please let me know the process for getting this patch reviewed?

Hi,

Your patch was already merged. Thanks for your patch!

https://git.openembedded.org/openembedded-core/commit/?id=4f96eaa0981b5d88a90de7641150423c01543d58

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com