public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Adam Duskett <adam.duskett@amarulasolutions.com>
To: openembedded-core@lists.openembedded.org
Cc: Adam Duskett <adam.duskett@amarulasolutions.com>
Subject: [PATCH v5 2/8] signing-keys.bb: Fix DISTRO_CODENAME truncation
Date: Mon, 23 Feb 2026 16:39:23 +0100	[thread overview]
Message-ID: <20260223153929.2641007-2-adam.duskett@amarulasolutions.com> (raw)
In-Reply-To: <20260223153929.2641007-1-adam.duskett@amarulasolutions.com>

If DISTRO_CODENAME is not set in the environment, bash quietly
drops the string resulting in a key such as PACKAGEFEED-GPG-KEY-defaultsetup-

However, when python calls self.d.getVar('DISTRO_CODENAME'), the resulting
string is 'None', leading to a configuration file pointing to a key such
as PACKAGEFEED-GPG-KEY-defaultsetup-None

Add a default value in signing-keys.bb to set DISTRO_CODENAME to None if
DISTRO_CODENAME is not set.

Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
 meta/recipes-core/meta/signing-keys.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/recipes-core/meta/signing-keys.bb b/meta/recipes-core/meta/signing-keys.bb
index 94f4032911..c7713ed4a6 100644
--- a/meta/recipes-core/meta/signing-keys.bb
+++ b/meta/recipes-core/meta/signing-keys.bb
@@ -45,6 +45,10 @@ addtask get_public_keys before do_install
 do_get_public_keys[depends] += "gnupg-native:do_populate_sysroot"
 
 do_install () {
+    # Python evalutes an empty DISTRO_CODENAME to "None" which would cause mismatched files
+    # as the update config file would show GPG-KEY-${DISTRO}-None but the filename is
+    # installed as GPG-KEY-${DISTRO}-
+    DISTRO_CODENAME="${DISTRO_CODENAME:-None}"
     if [ -f "${B}/rpm-key" ]; then
         install -D -m 0644 "${B}/rpm-key" "${D}${sysconfdir}/pki/rpm-gpg/RPM-GPG-KEY-${DISTRO}-${DISTRO_CODENAME}"
     fi
@@ -57,6 +61,7 @@ do_install () {
 }
 
 do_deploy () {
+    DISTRO_CODENAME="${DISTRO_CODENAME:-None}"
     if [ -f "${B}/rpm-key" ]; then
         install -D -m 0644 "${B}/rpm-key" "${DEPLOYDIR}/RPM-GPG-KEY-${DISTRO}-${DISTRO_CODENAME}"
     fi
-- 
2.53.0



  reply	other threads:[~2026-02-23 15:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 15:39 [PATCH v5 1/8] rpm/rootfs.py: ensure exit 1 has a word boundary Adam Duskett
2026-02-23 15:39 ` Adam Duskett [this message]
2026-02-23 15:39 ` [PATCH v5 3/8] libtoml11: new recipe Adam Duskett
2026-02-23 15:39 ` [PATCH v5 4/8] libsolv: explicitly enable comps for rpm packageconfig Adam Duskett
2026-02-23 15:39 ` [PATCH v5 5/8] librepo: upgrade 1.20.0 -> 1.21.0 Adam Duskett
2026-02-23 15:39 ` [PATCH v5 6/8] librepo: add PACKAGECONFIG[sequoia] Adam Duskett
2026-02-23 15:39 ` [PATCH v5 7/8] dnf: Upgrade to 5.4.0.0 Adam Duskett
2026-02-24  6:51   ` [OE-core] " Mathieu Dubois-Briand
2026-02-23 15:39 ` [PATCH v5 8/8] libdnf: remove recipe Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260223153929.2641007-2-adam.duskett@amarulasolutions.com \
    --to=adam.duskett@amarulasolutions.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox