public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Ross Burton <ross.burton@arm.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 2/4] lzop: improve aclocal.m4 handling
Date: Wed, 25 Feb 2026 12:37:24 +0000	[thread overview]
Message-ID: <20260225123727.2043715-2-ross.burton@arm.com> (raw)
In-Reply-To: <20260225123727.2043715-1-ross.burton@arm.com>

This upstream has a hand-maintained aclocal.m4 which we don't want to
delete (autotools.bbclass does this).  For some reason this was worked
around by shipping a copy of aclocal.m4 as acinclude.m4 and dropping
that into the build tree.

A better solution is to just exclude aclocal in EXTRA_AUTORECONF, which
has the side-effect of not removing the file.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-support/lzop/lzop_1.04.bb | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/meta/recipes-support/lzop/lzop_1.04.bb b/meta/recipes-support/lzop/lzop_1.04.bb
index c32aa534228..57c2190cf40 100644
--- a/meta/recipes-support/lzop/lzop_1.04.bb
+++ b/meta/recipes-support/lzop/lzop_1.04.bb
@@ -12,15 +12,12 @@ LICENSE = "GPL-2.0-or-later"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
                     file://src/lzop.c;beginline=5;endline=21;md5=23d767de7754eb24b9e900b025cf7fc8"
 
-SRC_URI = "http://www.lzop.org/download/${BP}.tar.gz \
-           file://acinclude.m4 \
-          "
+SRC_URI = "http://www.lzop.org/download/${BP}.tar.gz"
 SRC_URI[sha256sum] = "7e72b62a8a60aff5200a047eea0773a8fb205caf7acbe1774d95147f305a2f41"
 
 inherit autotools
 
-do_configure:prepend () {
-    install -Dm 0644 ${UNPACKDIR}/acinclude.m4 ${S}/acinclude.m4
-}
+# Ensure we don't delete the shipped aclocal.m4
+EXTRA_AUTORECONF += "--exclude=aclocal"
 
 BBCLASSEXTEND = "native nativesdk"
-- 
2.43.0



  reply	other threads:[~2026-02-25 12:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 12:37 [PATCH 1/4] readline: improve aclocal.m4 handling Ross Burton
2026-02-25 12:37 ` Ross Burton [this message]
2026-02-25 18:58   ` [OE-core] [PATCH 2/4] lzop: " Peter Kjellerstedt
2026-03-02 13:49     ` Ross Burton
2026-02-25 12:37 ` [PATCH 3/4] rxvt: " Ross Burton
2026-02-25 12:37 ` [PATCH 4/4] autotools: remove deletion of aclocal.m4 Ross Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260225123727.2043715-2-ross.burton@arm.com \
    --to=ross.burton@arm.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox