public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Michal Sieron <michalwsieron@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Michal Sieron <michalwsieron@gmail.com>
Subject: [PATCH v2 02/12] coreutils: Convert confusing append to override syntax
Date: Tue, 17 Mar 2026 01:03:06 +0100	[thread overview]
Message-ID: <20260317-fix-invalid-appends-v2-2-5c65ae5787d9@gmail.com> (raw)
In-Reply-To: <20260317-fix-invalid-appends-v2-0-5c65ae5787d9@gmail.com>

:class-target overrides for PACKAGE_BEFORE_PN and RDEPENDS:coreutils
were being appended to with the coreutils-stdbuf, but instead of being
an append only for target builds, it was actually overriding those
variables.

One could replace `:class-target +=` with `:append:class-target =`, but
I don't think there is actually any need for this to be :class-target
specific. RPROVIDES:coreutils few lines below doesn't use that override.

Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
---
 meta/recipes-core/coreutils/coreutils_9.10.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/coreutils/coreutils_9.10.bb b/meta/recipes-core/coreutils/coreutils_9.10.bb
index 984c5b5292..fb254d047d 100644
--- a/meta/recipes-core/coreutils/coreutils_9.10.bb
+++ b/meta/recipes-core/coreutils/coreutils_9.10.bb
@@ -66,9 +66,9 @@ sbindir_progs = "chroot"
 # coreutils-stdbuf without getting the rest of coreutils, but make
 # coreutils itself pull in stdbuf, so IMAGE_INSTALL += "coreutils"
 # always provides all coreutils
-PACKAGE_BEFORE_PN:class-target += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', '', 'coreutils-stdbuf', d)}"
+PACKAGE_BEFORE_PN += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', '', 'coreutils-stdbuf', d)}"
 FILES:coreutils-stdbuf = "${bindir}/stdbuf ${libdir}/coreutils/libstdbuf.so"
-RDEPENDS:coreutils:class-target += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', '', 'coreutils-stdbuf', d)}"
+RDEPENDS:coreutils += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', '', 'coreutils-stdbuf', d)}"
 
 # However, when the single-binary PACKAGECONFIG is used, stdbuf
 # functionality is built into the single coreutils binary, so there's

-- 
2.53.0



  parent reply	other threads:[~2026-03-17  0:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  0:03 [PATCH v2 00/12] Confusing and invalid conditional appends Michal Sieron
2026-03-17  0:03 ` [PATCH v2 01/12] libffi: Fix invalid conditional append Michal Sieron
2026-03-17  0:38   ` [OE-core] " Khem Raj
2026-03-17  0:03 ` Michal Sieron [this message]
2026-03-17  0:03 ` [PATCH v2 03/12] expat: Convert confusing append to override syntax Michal Sieron
2026-03-17  0:41   ` [OE-core] " Khem Raj
2026-03-17  0:03 ` [PATCH v2 04/12] tune-power[567]: Remove confusing overrides Michal Sieron
2026-03-17  0:03 ` [PATCH v2 05/12] no-gplv3.inc: Convert confusing appends to override syntax Michal Sieron
2026-03-17  0:44   ` [OE-core] " Khem Raj
2026-03-17  0:03 ` [PATCH v2 06/12] bootchart2: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 07/12] pigz: Convert confusing append " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 08/12] systemtap: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 09/12] ovmf: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 10/12] dnf: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 11/12] qemu: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 12/12] recipes-devtools/python: Convert confusing appends " Michal Sieron
2026-03-17  0:50 ` [OE-core] [PATCH v2 00/12] Confusing and invalid conditional appends Khem Raj
2026-03-17 19:09   ` Michal Sieron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317-fix-invalid-appends-v2-2-5c65ae5787d9@gmail.com \
    --to=michalwsieron@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox