Re: [OE-core] [PATCH v3 00/13] Confusing and invalid conditional appends

Khem Raj
2026-03-17T20:33:36Z

[-- Attachment #1: Type: text/plain, Size: 4307 bytes --]

this version looks good.

On Tue, Mar 17, 2026 at 1:29 PM Michal Sieron via lists.openembedded.org
<michalwsieron=gmail.com@lists.openembedded.org> wrote:

> This patchset fixes several findings for variable assignments of form:
> A:someoverride += "foo"
> and transforms them into:
> A:append:someoverride = " foo"
>
> In most of those cases I assume the original intent was to have a
> conditional append, but what was actually happening was append to
> a conditional override.
>
> I first noticed such problem in our internal recipes and bbappends, but
> then I decided to check if similar issue exists upstream and turns out
> it does.
>
> ---
> Changes in v3:
> - Use normal assignment in libffi and expat instead
> - Fix package name typo in musl-locales
> - Link to v2:
> https://lore.kernel.org/r/20260317-fix-invalid-appends-v2-0-5c65ae5787d9@gmail.com
>
> Changes in v2:
> - Split initial single commit into smaller ones
> - Described actual impact on the overriden variables
> - Added some recipes that I missed last time
> - Link to v1:
> https://lore.kernel.org/r/20260314-fix-invalid-appends-v1-1-03ec0bff6942@gmail.com
>
> ---
> Michal Sieron (13):
> libffi: Convert confusing append to assignment
> coreutils: Convert confusing append to override syntax
> expat: Convert confusing append to assignment
> tune-power[567]: Remove confusing overrides
> no-gplv3.inc: Convert confusing appends to override syntax
> bootchart2: Convert confusing appends to override syntax
> pigz: Convert confusing append to override syntax
> systemtap: Convert confusing append to override syntax
> ovmf: Convert confusing append to override syntax
> dnf: Convert confusing append to override syntax
> qemu: Convert confusing append to override syntax
> recipes-devtools/python: Convert confusing appends to override syntax
> musl-locales: Fix locale-base-sr-sr typo
>
> meta/conf/distro/include/no-gplv3.inc | 4 ++--
> meta/conf/machine/include/powerpc/tune-power5.inc | 3 +--
> meta/conf/machine/include/powerpc/tune-power6.inc | 3 +--
> meta/conf/machine/include/powerpc/tune-power7.inc | 3 +--
> meta/recipes-core/coreutils/coreutils_9.10.bb | 4 ++--
> meta/recipes-core/expat/expat_2.7.4.bb | 2 +-
> meta/recipes-core/musl/musl-locales_git.bb | 2 +-
> meta/recipes-core/ovmf/ovmf_git.bb | 2 +-
> meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb | 10 +++++-----
> meta/recipes-devtools/dnf/dnf_4.24.0.bb | 2 +-
> meta/recipes-devtools/python/python3-asn1crypto_1.5.1.bb | 2 +-
> meta/recipes-devtools/python/python3-bcrypt_5.0.0.bb | 2 +-
> meta/recipes-devtools/python/python3-chardet_5.2.0.bb | 2 +-
> meta/recipes-devtools/python/python3-cython_3.2.4.bb | 4 ++--
> meta/recipes-devtools/python/python3-ply_3.11.bb | 2 +-
> meta/recipes-devtools/python/python3-pyasn1_0.6.2.bb | 2 +-
> meta/recipes-devtools/python/python3-pycparser_3.0.bb | 4 ++--
> meta/recipes-devtools/python/python3-pysocks_1.7.1.bb | 2 +-
> meta/recipes-devtools/python/python3-pytz_2025.2.bb | 2 +-
> meta/recipes-devtools/qemu/qemu_10.2.0.bb | 2 +-
> meta/recipes-extended/pigz/pigz_2.8.bb | 2 +-
> meta/recipes-kernel/systemtap/systemtap_5.4.bb | 2 +-
> meta/recipes-support/libffi/libffi_3.5.2.bb | 2 +-
> 23 files changed, 31 insertions(+), 34 deletions(-)
> ---
> base-commit: 2dc4d2f8b5c7a6e87291385fb860436593767199
> change-id: 20260314-fix-invalid-appends-cf5197ef2f07
>
> Best regards,
> --
> Michal Sieron <michalwsieron@gmail.com>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#233335):
> https://lists.openembedded.org/g/openembedded-core/message/233335
> Mute This Topic: https://lists.openembedded.org/mt/118372180/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 7240 bytes --]