public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Khalifa Rouis <khalifa@missingno.tech>
To: openembedded-core@lists.openembedded.org
Cc: Khalifa Rouis <khalifa@missingno.tech>
Subject: [PATCH] weston-init: fix variable expansion typo in weston-start
Date: Tue, 24 Mar 2026 21:49:19 +0100	[thread overview]
Message-ID: <20260324204919.787216-1-khalifa@missingno.tech> (raw)

The variable weston_modules was incorrectly enclosed as {$weston_modules}
instead of ${weston_modules}.
This typo prevents proper bash variable expansion when checking for and
appending Weston module arguments.

This commit corrects the syntax to ensure the modules are properly
evaluated.

Fixes: c8aa0222ce2b ("weston: wrapper for weston modules argument")
Signed-off-by: Khalifa Rouis <khalifa@missingno.tech>
---
 meta/recipes-graphics/wayland/weston-init/weston-start | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/wayland/weston-init/weston-start b/meta/recipes-graphics/wayland/weston-init/weston-start
index 3b13a0047a..38aa0c6e27 100755
--- a/meta/recipes-graphics/wayland/weston-init/weston-start
+++ b/meta/recipes-graphics/wayland/weston-init/weston-start
@@ -50,7 +50,7 @@ if [ -d "$modules_dir" ]; then
 
 		# process module
 		. $m
-		if [[ x"{$weston_modules}" != "x" ]]; then
+		if [[ x"${weston_modules}" != "x" ]]; then
 			add_weston_argument "${weston_modules}"
 		fi;
 	done
-- 
2.43.0



                 reply	other threads:[~2026-03-24 20:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260324204919.787216-1-khalifa@missingno.tech \
    --to=khalifa@missingno.tech \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox