public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Shotaro Uchida <fantom.jac@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Shotaro Uchida <suchida@uaudio.com>
Subject: [PATCH] insane: appendVarFlags must be preceded by a whitespace
Date: Fri, 27 Mar 2026 16:15:18 -0700	[thread overview]
Message-ID: <20260327231518.19822-1-suchida@uaudio.com> (raw)

appendVarFlags is not automatically adding a whitespace, user must add a
white space before the value to be added. Current usage may break
INSANE_SKIP:${PN} vardeps flag value by adding QAPATHTEST functions
immediately without a whitespace. e.g. It will become something like
INSANE_SKIP:${PN}package_qa_check_shebang_size

Signed-off-by: Shotaro Uchida <suchida@uaudio.com>
---
 meta/classes-global/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index 8bbe5bb19a..4ccc532282 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -1207,7 +1207,7 @@ python() {
     funcs = d.getVarFlags("QAPATHTEST")
     funcs.update(d.getVarFlags("QAPKGTEST"))
     funcs.update(d.getVarFlags("QARECIPETEST"))
-    d.appendVarFlag("do_package_qa", "vardeps", " ".join(funcs.values()))
+    d.appendVarFlag("do_package_qa", "vardeps", " {}".format(" ".join(funcs.values())))
 }
 
 SSTATETASKS += "do_package_qa"
-- 
2.51.0



             reply	other threads:[~2026-03-27 23:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 23:15 Shotaro Uchida [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-27 23:09 [PATCH] insane: appendVarFlags must be preceded by a whitespace Shotaro Uchida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260327231518.19822-1-suchida@uaudio.com \
    --to=fantom.jac@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=suchida@uaudio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox