Re: [PATCH] devtool-source: set S variable to a sub dir of UNPACKDIR

Richard Purdie
2026-04-16T10:32:02Z

On Thu, 2026-04-16 at 10:14 +0200, Benjamin Robin (Schneider Electric) wrote:
> If a recipe set UNPACKDIR to a directory that is not contained within
> WORKDIR, before this modification, this generates the following error:
> "S should be set relative to UNPACKDIR."
>
> S should not be updated, otherwise the recipe may not find the extracted
> sources. In all recipes, S should reference the UNPACKDIR variable.
> There is an exception for the kernel to prevent infinite recursion
> when expanding the STAGING_KERNEL_DIR variable.
>
> So, only updates UNPACKDIR to be within the DEVTOOL_TEMPDIR directory.
>
> Signed-off-by: Benjamin Robin (Schneider Electric) <benjamin.robin@bootlin.com>
> ---
> I have done various testing, but since I don't know all the requirements
> of devtool, and all the impacts of this change, I may have broken some
> stuff (I hope not).
>
> This patch fixes the following command:
>  - devtool upgrade sbom-cve-check-update-cvelist-native
>
> It does not break the following commands:
>  - devtool upgrade linux-yocto
>  - devtool upgrade python3-sbom-cve-check

For reference devtool has a strong test suite and you can run it with
"oe-selftest -r devtool".

Cheers,

Richard