public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 2/3] shadow: Disable tallylog execution
Date: Tue, 21 Apr 2026 11:41:46 +0100	[thread overview]
Message-ID: <20260421104147.1994119-2-richard.purdie@linuxfoundation.org> (raw)
In-Reply-To: <20260421104147.1994119-1-richard.purdie@linuxfoundation.org>

We don't want to be calling tallylog from our native tools, disable it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 .../shadow/files/notallylog.patch             | 19 +++++++++++++++++++
 meta/recipes-extended/shadow/shadow_4.19.4.bb |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 meta/recipes-extended/shadow/files/notallylog.patch

diff --git a/meta/recipes-extended/shadow/files/notallylog.patch b/meta/recipes-extended/shadow/files/notallylog.patch
new file mode 100644
index 00000000000..94773ace2ba
--- /dev/null
+++ b/meta/recipes-extended/shadow/files/notallylog.patch
@@ -0,0 +1,19 @@
+We don't want to call /sbin/pam_tally2 in the native tools case so
+disable this function.
+
+Upstream-Status: Inappropriate [OE cross configuration specific]
+
+Index: shadow-4.19.4/src/useradd.c
+===================================================================
+--- shadow-4.19.4.orig/src/useradd.c
++++ shadow-4.19.4/src/useradd.c
+@@ -2046,6 +2046,9 @@ static void tallylog_reset (const char *
+ 	int failed;
+ 	int status;
+ 
++	/* Don't call /sbin/pam_tally2 in native builds */
++	return;
++
+ 	if (access(pam_tally2, X_OK) == -1)
+ 		return;
+ 
diff --git a/meta/recipes-extended/shadow/shadow_4.19.4.bb b/meta/recipes-extended/shadow/shadow_4.19.4.bb
index 9fe6a27e411..3ab9ae9c287 100644
--- a/meta/recipes-extended/shadow/shadow_4.19.4.bb
+++ b/meta/recipes-extended/shadow/shadow_4.19.4.bb
@@ -25,6 +25,7 @@ SRC_URI:append:class-target = " \
 SRC_URI:append:class-native = " \
            file://commonio.c-fix-unexpected-open-failure-in-chroot-env.patch \
            file://disable_syslog.patch \
+           file://notallylog.patch \
            "
 SRC_URI[sha256sum] = "ba7e9aed1c5420203ac549583d6e6f485a819ac7505af9c7cd8c13b2013210b8"
 UPSTREAM_CHECK_REGEX = "releases/tag/v?(?P<pver>\d+(\.\d+)+)$"


  reply	other threads:[~2026-04-21 10:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 10:41 [PATCH 1/3] pseudo: Update to 1.7.4 Richard Purdie
2026-04-21 10:41 ` Richard Purdie [this message]
2026-04-21 11:00   ` Patchtest results for [PATCH 2/3] shadow: Disable tallylog execution patchtest
2026-04-21 10:41 ` [PATCH 3/3] shadow: Drop pointless patch Richard Purdie
2026-04-22  5:51   ` [OE-core] " ChenQi
2026-04-22  6:44     ` Richard Purdie
2026-04-21 11:41 ` [OE-core] [PATCH 1/3] pseudo: Update to 1.7.4 Yoann Congal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260421104147.1994119-2-richard.purdie@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox