Re: [OE-core] [PATCH 1/2] devtool: standard: guess srcrev update mode for gitsm:// recipes too

[Babanpreet Singh <bbnpreetsingh@gmail.com>]

Hi Mathieu,

Thanks for the report. I dug into the three failures on build 4355:
one is a real regression in my patch (fixed in v2), the other two
don't look caused by this series.

1) test_devtool_git_submodules: my fault. The test commits inside a
submodule, so the parent HEAD stays on the upstream branch and v1
guessed srcrev, which only rewrites the parent SRCREV and so
silently dropped the submodule commit. v2 only guesses srcrev when
'git submodule status --recursive' shows every submodule in sync,
keeping such trees in patch mode. The test fails here with v1 and
passes with v2, matching the autobuilder.

2) test_devtool_modify_nested_gitsm fails during 'devtool modify'
source extraction ("No url found for submodule path
'nested/repo-gitsm' in .gitmodules"), before the update-mode guesser
(the only thing this series touches) can run.

3) test_devtool_finish_update_patch: sysdig-selftest has no gitsm://
URIs, so the change is inert for it.

Both 2) and 3) pass here on master with only this series applied.
Build 4355 tested mathieu/master-next, and the nested-git destsuffix
rework in that queue touches exactly the machinery both failures
point at, so I suspect an interaction with that series. Happy to be
corrected if they still fail without other devtool changes in the
queue.

v2 also adopts Richard's startswith-tuple suggestion.

Thanks,
Baban