From: Trevor Woerner <twoerner@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v4 03/10] oeqa/selftest/wic: drop dead COREBASE/scripts wic lookup
Date: Fri, 24 Jul 2026 05:01:39 -0400 [thread overview]
Message-ID: <20260724090146.19924-4-twoerner@gmail.com> (raw)
In-Reply-To: <20260724090146.19924-1-twoerner@gmail.com>
_get_wic_path() searches for the wic binary in two locations: the
in-tree scripts directory and the wic-tools native sysroot. wic was
moved to a standalone repository and is no longer shipped in
scripts/, so scripts/wic never exists and the first search path can
never match.
Look for wic only in the wic-tools native sysroot, where the wic
recipe installs it, and fail with that path if it is missing.
AI-Generated: codex/claude-opus 4.8 (xhigh)
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
changes in v4:
- new in v4
---
meta/lib/oeqa/selftest/cases/wic.py | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/meta/lib/oeqa/selftest/cases/wic.py b/meta/lib/oeqa/selftest/cases/wic.py
index c4a1c7241bbc..6a2706fc2c8f 100644
--- a/meta/lib/oeqa/selftest/cases/wic.py
+++ b/meta/lib/oeqa/selftest/cases/wic.py
@@ -107,18 +107,11 @@ class WicTestCase(OESelftestTestCase):
def _get_wic_path(self):
if WicTestCase.wic_bindir is None:
- search_paths = [
- os.path.join(self.td['COREBASE'], 'scripts'),
- os.path.join(get_bb_var('RECIPE_SYSROOT_NATIVE', 'wic-tools'), 'usr', 'bin'),
- ]
-
- for bindir in search_paths:
- if os.path.exists(os.path.join(bindir, 'wic')):
- WicTestCase.wic_bindir = bindir
- break
-
- if WicTestCase.wic_bindir is None:
- self.fail("Unable to find the wic binary in %s" % ', '.join(search_paths))
+ bindir = os.path.join(get_bb_var('RECIPE_SYSROOT_NATIVE', 'wic-tools'),
+ 'usr', 'bin')
+ if not os.path.exists(os.path.join(bindir, 'wic')):
+ self.fail("Unable to find the wic binary in %s" % bindir)
+ WicTestCase.wic_bindir = bindir
path_entries = []
for path_group in (
--
2.50.0.173.g8b6f19ccfc3a
next prev parent reply other threads:[~2026-07-24 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 9:01 [PATCH v4 00/10] wic: ship its tools, and add an SDK_FEATURES lever Trevor Woerner
2026-07-24 9:01 ` [PATCH v4 01/10] wic-tools: move bootloader firmware staging into the wic oe-selftest Trevor Woerner
2026-07-24 9:01 ` [PATCH v4 02/10] wic: add runtime dependencies on the tools it invokes Trevor Woerner
2026-07-24 9:01 ` Trevor Woerner [this message]
2026-07-24 9:01 ` [PATCH v4 04/10] oeqa/selftest/wic: drop redundant per-test PATH overrides Trevor Woerner
2026-07-24 9:01 ` [PATCH v4 05/10] nativesdk-packagegroup-sdk-host: add an SDK_FEATURES lever Trevor Woerner
2026-07-24 9:01 ` [PATCH v4 06/10] nativesdk-packagegroup-sdk-host: add wic to SDK_FEATURES Trevor Woerner
2026-07-24 9:01 ` [PATCH v4 07/10] nativesdk-packagegroup-sdk-host: add an sbom SDK feature Trevor Woerner
2026-07-24 9:01 ` [PATCH v4 08/10] nativesdk-packagegroup-sdk-host: add an lldb " Trevor Woerner
2026-07-24 9:01 ` [PATCH v4 09/10] nativesdk-packagegroup-sdk-host: gate qemu behind SDK_FEATURES Trevor Woerner
2026-07-24 9:21 ` Patchtest results for " patchtest
2026-07-24 9:01 ` [PATCH v4 10/10] packagegroup-cross-canadian: gate gdb " Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724090146.19924-4-twoerner@gmail.com \
--to=twoerner@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox