Openembedded Core Discussions
 help / color / mirror / Atom feed
From: <daniel.turull@ericsson.com>
To: <openembedded-core@lists.openembedded.org>
Cc: <JPEWhacker@gmail.com>, <mathieu.dubois-briand@bootlin.com>,
	Daniel Turull <daniel.turull@ericsson.com>
Subject: [PATCH v6 1/3] oe/reproducible: exclude __CACHED_SOURCE_DATE_EPOCH from task hash
Date: Fri, 16 Oct 2026 12:56:09 +0200	[thread overview]
Message-ID: <20261016105611.330514-2-daniel.turull@ericsson.com> (raw)
In-Reply-To: <20261016105611.330514-1-daniel.turull@ericsson.com>

From: Daniel Turull <daniel.turull@ericsson.com>

epochfile_read() memoizes its result into __CACHED_SOURCE_DATE_EPOCH
via d.setVar(), so its runtime value leaks into the basehash of any
task that calls it, causing a "metadata is not deterministic" error
once SDE_FILE is populated.

Exclude it, since it is not meaningful build metadata, using the
bb.parse.vardepsexclude decorator on the function itself.

AI-Generated: Uses Kiro with Claude Sonnet 5
Signed-off-by: Daniel Turull <daniel.turull@ericsson.com>
---
This should fix the selftest errors reported by Mathieu

v6: use bb.parse.vardepsexclude as requested by Richard
---
 meta/lib/oe/reproducible.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/lib/oe/reproducible.py b/meta/lib/oe/reproducible.py
index a80376010a..d8e1dc825f 100644
--- a/meta/lib/oe/reproducible.py
+++ b/meta/lib/oe/reproducible.py
@@ -156,6 +156,9 @@ def get_source_date_epoch(d, sourcedir):
         fixed_source_date_epoch(d)       # Last resort
     )
 
+# epochfile_read() memoizes into __CACHED_SOURCE_DATE_EPOCH via d.setVar(), so
+# its runtime value must not leak into any task's hash.
+@bb.parse.vardepsexclude("__CACHED_SOURCE_DATE_EPOCH")
 def epochfile_read(epochfile, d):
     cached, efile = d.getVar('__CACHED_SOURCE_DATE_EPOCH') or (None, None)
     if cached and efile == epochfile:


  reply	other threads:[~2026-10-16 10:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 10:56 [PATCH v6 0/3] spdx: add support to include releaseTime daniel.turull
2026-10-16 10:56 ` daniel.turull [this message]
2026-10-16 10:56 ` [PATCH v6 2/3] create-spdx-3.0: record component release date in SPDX output daniel.turull
2026-10-16 10:56 ` [PATCH v6 3/3] scripts/contrib: add spdx-release-date-report.py daniel.turull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016105611.330514-2-daniel.turull@ericsson.com \
    --to=daniel.turull@ericsson.com \
    --cc=JPEWhacker@gmail.com \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox