Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Stefano Tondo <stondo@gmail.com>
To: Paul Barker <paul@pbarker.dev>
Cc: openembedded-core@lists.openembedded.org,
	Joshua Watt <JPEWhacker@gmail.com>,
	Alexander Kanavin <alex.kanavin@gmail.com>,
	Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,
	Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>,
	stefano.tondo.ext@siemens.com
Subject: Re: [PATCH v2 4/4] oeqa/selftest: spdx: Test crate identity, scope and output PURLs
Date: Thu, 19 Nov 2026 11:30:29 +0100	[thread overview]
Message-ID: <20261119103029.311675-1-stondo@gmail.com> (raw)
In-Reply-To: <DMZ3O22TVVFQ.155PGZ293VQJO@pbarker.dev>

On Thu Nov 19, 2026 at 10:03 AM GMT, Paul Barker wrote:
> Does it use a fixed version of the python3-bcrypt recipe or just
> whatever version is currently in OE-Core?

Hi Paul,

It uses the version that is currently in OE-Core. There is no copy of
the recipe in meta-selftest.

> If it tracks the version used in OE-Core, is it likely to start failing
> when python3-bcrypt adds or removes dependencies in the future?

I do not expect it to fail. I wrote the tests for this case. They do
not contain crate versions or crate counts. The 42 crates are only in the
commit message. The tests get the expected values from the build:

- The name, version and PURL of each crate must agree with its
  crates.io download URL.
- Each crate must have exactly one lifecycle scope, or an annotation
  that it is not built.
- The cargo PURLs of the output package must be equal to the set of
  crates that have the runtime scope in the build SPDX.

When the recipe adds or removes a dependency, these sets change together.

The tests use three facts about the dependencies of python3-bcrypt:

- blowfish has the runtime scope. It is the cipher of bcrypt.
- syn has the build scope. The pyo3 proc-macros use it.
- At least one crate is for another platform, so it is not built.
  Today there are five: r-efi, wasi, wasip2 and wit-bindgen come
  from getrandom, and portable-atomic comes from pyo3.

Only a large change in bcrypt or pyo3 can make the first two false.
The third is less certain, but getrandom supports WebAssembly and UEFI,
and it is unlikely to stop. If this check fails, the message shows the
fact that changed. Then we can use a different crate or remove the
check.

Best regards,
Stefano

  reply	other threads:[~2026-11-19 10:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 23:44 [PATCH v2 0/4] spdx30: identity and purls of dependency downloads Stefano Tondo
2026-11-18 23:44 ` [PATCH v2 1/4] spdx30: Take name, version and PURL of downloads from the fetcher Stefano Tondo
2026-11-18 23:44 ` [PATCH v2 2/4] spdx30: Record the lifecycle scope of crate dependencies Stefano Tondo
2026-11-18 23:44 ` [PATCH v2 3/4] spdx30: Add the PURLs of the source downloads to the output packages Stefano Tondo
2026-11-18 23:44 ` [PATCH v2 4/4] oeqa/selftest: spdx: Test crate identity, scope and output PURLs Stefano Tondo
2026-11-19 10:03   ` Paul Barker
2026-11-19 10:30     ` Stefano Tondo [this message]
2026-11-19 12:34 ` [PATCH v2 0/4] spdx30: identity and purls of dependency downloads Mathieu Dubois-Briand
2026-11-19 13:35   ` Stefano Tondo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119103029.311675-1-stondo@gmail.com \
    --to=stondo@gmail.com \
    --cc=JPEWhacker@gmail.com \
    --cc=alex.kanavin@gmail.com \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul@pbarker.dev \
    --cc=stefan.herbrechtsmeier@weidmueller.com \
    --cc=stefano.tondo.ext@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox