From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: yocto@mac.mcrowe.com, openembedded-core@lists.openembedded.org
Cc: Mike Crowe <mac@mcrowe.com>
Subject: Re: [OE-core] [pseudo][PATCH] fcntl: Add support for F_GETPIPE_SZ
Date: Wed, 11 Aug 2021 22:38:23 +0100 [thread overview]
Message-ID: <20a5e86d077daf76bfc1398729b3a8ab71f9633c.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210811155821.863938-1-mac@mcrowe.com>
On Wed, 2021-08-11 at 16:58 +0100, Mike Crowe via lists.openembedded.org wrote:
> When running the test suite on my Debian 11 box I see many occurrences
> of:
>
> unknown fcntl argument 1032, assuming long argument.
>
> (for example from test-execl.sh.)
>
> It appears that this is F_GETPIPE_SZ and it takes no arguments. Let's
> add it to avoid the warning messages.
>
> I could add F_SETPIPE_SZ too, but that apparently takes an int argument
> which would mean moving the va_arg call into the switch statement. :(
>
> Signed-off-by: Mike Crowe <mac@mcrowe.com>
> ---
> ports/linux/guts/fcntl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ports/linux/guts/fcntl.c b/ports/linux/guts/fcntl.c
> index 434c7f3..e9c6140 100644
> --- a/ports/linux/guts/fcntl.c
> +++ b/ports/linux/guts/fcntl.c
> @@ -37,6 +37,9 @@
> case F_GETOWN:
> case F_GETSIG:
> case F_GETLEASE:
> +#if defined(F_GETPIPE_SZ)
> + case F_GETPIPE_SZ:
> +#endif
> rc = real_fcntl(fd, cmd);
> break;
> /* long argument */
This goes make to making pseudo host specific which will break uninative/sstate.
We'll probably have to add a define if it isn't defined to get the behaviour we
need.
It is probably only a question of time before some program is using F_SETPIPE_SZ
too :(
Cheers,
Richard
next prev parent reply other threads:[~2021-08-11 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:58 [pseudo][PATCH] fcntl: Add support for F_GETPIPE_SZ Mike Crowe
2021-08-11 21:38 ` Richard Purdie [this message]
2021-08-12 7:46 ` [OE-core] " Mike Crowe
[not found] ` <169A7F7B2DA70883.29477@lists.openembedded.org>
2021-08-13 10:07 ` Mike Crowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20a5e86d077daf76bfc1398729b3a8ab71f9633c.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=mac@mcrowe.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=yocto@mac.mcrowe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox