Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Ranjitsinh Rathod" <ranjitsinhrathod1991@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [meta][dunfell][PATCH] libinput: Add fix for CVE-2022-1215
Date: Tue, 10 May 2022 08:05:56 -0700	[thread overview]
Message-ID: <21438.1652195156118038664@lists.openembedded.org> (raw)
In-Reply-To: <20220509062438.12448-1-badganchipv@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]

Hi Steve,

It seems something is wrong with this patch and also in the patching tool within Yocto as well.

When I apply this patch, it is getting applied cleanly, without any warnings and/or patch-fuzz, which means the source code should reflect as per the patch.
But when I go to the source code on the path "build/tmp/work/<architecture>/libinput/1.15.2-r0/libinput-1.15.2" and see the file "src/evdev.c", it seems below two Hunk's are not getting reflected.

@@ -2469,7 +2478,7 @@ evdev_device_get_output(struct evdev_device *device)
const char *
evdev_device_get_sysname(struct evdev_device *device)
{
- return udev_device_get_sysname(device->udev_device);
+ return device->sysname;
}

const char *
@@ -3066,6 +3075,8 @@ evdev_device_destroy(struct evdev_device *device)
if (device->base.group)
libinput_device_group_unref(device->base.group);

+ free(device->log_prefix_name);
+ free(device->sysname);
free(device->output_name);
filter_destroy(device->pointer.filter);
libinput_timer_destroy(&device->scroll.timer);

Can you please check this from your end too? If this is the case, there is a serious issue where patching is failing silently which needs attention.

As I have seen the patch in the testing branch "http://cgit.openembedded.org/openembedded-core-contrib/commit/?h=stable/dunfell-nut&id=6a31bfaee4d715f31e69cea1eed05484d9d7a999" I considered to post this email as it seems you also did not get any warnings/error during the patching and even compilation.

Thanks,
Ranjitsinh Rathod

[-- Attachment #2: Type: text/html, Size: 2260 bytes --]

  reply	other threads:[~2022-05-10 15:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09  6:24 [meta][dunfell][PATCH] libinput: Add fix for CVE-2022-1215 Pawan Badganchi
2022-05-10 15:05 ` Ranjitsinh Rathod [this message]
2022-05-10 16:16   ` [OE-core] " Steve Sakoman
     [not found]   ` <16EDCA98FD0B8E23.32235@lists.openembedded.org>
2022-05-10 17:47     ` Steve Sakoman
2022-05-10 17:49 ` Steve Sakoman
2022-05-20 12:04   ` Ranjitsinh Rathod
2022-05-20 14:36     ` [OE-core] " Steve Sakoman
  -- strict thread matches above, loose matches on Subject: below --
2022-05-06  8:06 pawan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21438.1652195156118038664@lists.openembedded.org \
    --to=ranjitsinhrathod1991@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox