Re: [PATCH v2] meta/meta-selftest: add selftest-hello-mod recipe

["Dixit Parmar" <dixitparmar19@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]

On Thu, Jun 19, 2025 at 05:10 PM, Mathieu Dubois-Briand wrote:

> 
> On Thu Jun 19, 2025 at 7:56 AM CEST, Dixit Parmar via
> lists.openembedded.org wrote:
> 
>> On Thu, Jun 19, 2025 at 10:15 AM, Mathieu Dubois-Briand wrote:
>> 
>> 
>>> On Mon Jun 9, 2025 at 3:41 PM CEST, Dixit Parmar via
>>> lists.openembedded.org wrote:
>>> 
>>> 
>>>> Kernel module specific oe test cases requires a test kernel
>>>> module package to work with. Added selftest-hello-mod
>>>> derived from meta-skeleton/recipes-kernel/hello-mod.
>>>> 
>>>> Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>
>>>> ---
>>> 
>>> Thanks or your patch.
>>> 
>>> 
>>> 
>>>> +S = "${WORKDIR}/hello-mod"
>>> 
>>> This will trigger an error if some patches in master-next are merged,
>>> you can rebase on master-next to see the error. The hello-mod recipe of
>>> meta-skeleton was also updated accordingly.
>> 
>> Do you mean I should take the latest reference from master-next for the
>> meta-skeleton/hello-mod to meta-selftest?
> 
> All I can say for sure is we cannot take both the series from Alexander
> and your patch as-is.
> 
> So as I believe the said series is likely to be merged, I would indeed
> suggest to modify your patch accordingly, and this can be done by taking
> the last version of meta-skeleton/hello-mod. But again, I'm not the one
> deciding what gets merged, so I cannot be sure if and when it will be
> merged.

Understood. A failure was reported with the previous version of this patch, where the .bb file was missing the WORKDIR-related changes for ${S} as it was directly taken from the meta-skeleton/hello-mod. Now, to fix that, I have incorporated the solution this way. do you think this will give errors too? Pls don't misunderstand me, I get your point of rebasing to the latest meta-skeleton as reference but I just want to understand if this will get failed or not. because the said master-next patch sets are still yet to get merged.

> 
> --
> Mathieu Dubois-Briand, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

[-- Attachment #2: Type: text/html, Size: 2287 bytes --]