From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mail.openembedded.org (Postfix) with ESMTP id C2A5D71B29 for ; Tue, 13 Dec 2016 06:33:11 +0000 (UTC) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP; 12 Dec 2016 22:33:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,340,1477983600"; d="scan'208";a="911577727" Received: from mauric9x-mobl.amr.corp.intel.com (HELO peggleto-mobl.ger.corp.intel.com) ([10.255.158.7]) by orsmga003.jf.intel.com with ESMTP; 12 Dec 2016 22:33:10 -0800 From: Paul Eggleton To: Robert Yang Date: Tue, 13 Dec 2016 19:33:08 +1300 Message-ID: <2244665.P00pJDD7kM@peggleto-mobl.ger.corp.intel.com> Organization: Intel Corporation User-Agent: KMail/4.14.10 (Linux/4.8.12-100.fc23.x86_64; KDE/4.14.20; x86_64; ; ) In-Reply-To: References: <4153349.TypEQkvbtP@peggleto-mobl.ger.corp.intel.com> MIME-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 5/8] oeqa/sdkext/devtool.py: don't reset when the test is failed X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2016 06:33:12 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Tue, 13 Dec 2016 14:01:08 Robert Yang wrote: > On 12/13/2016 12:48 PM, Paul Eggleton wrote: > > On Wed, 16 Nov 2016 22:19:34 Robert Yang wrote: > >> The contents are helpful to debug when the error happens. > > > > In this case removing this is OK because we're operating on an eSDK that > > the tests install. However, this wouldn't be appropriate for the devtool > > oe- selftest tests since they are operating on the user's build system > > itself - not that you probably have any intention of changing those, I > > just wanted to note that. > > Sorry, I don't quite understand, does selftest uses oeqa/sdkext/devtool.py, > please ? No, this is for bitbake -c testsdkext. > Even if it uses devtool.py, I still think that we need keep the > error contents for debugging when the error happens. It's very hard to > debug when there is no error log or no workspace. I mean the equivalent oe-selftest tests in oeqa/selftest/devtool.py. Actually, I've realised something that applies here as well - leaving the files around would be OK if we stopped on the first failure, but we don't - the next test proceeds after it. How will you be able to rely on what's in the workspace if several other tests have run afterwards - not to mention ensure those tests aren't disrupted by the leftover files? Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre