From: "Martin Beeger" <martin.beeger@online.de>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] cmake: read asm flags correctly from environment in toolchain file
Date: Mon, 18 Jul 2022 09:47:10 -0700 [thread overview]
Message-ID: <22536.1658162830175506094@lists.openembedded.org> (raw)
In-Reply-To: <12b94281-a1c7-f847-a1f7-011669e5cde0@online.de>
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
I looked further, and the variable is misspelt and should be CMAKE_AS_FLAGS to have any effect. Furthermore, it is not recommended to set it explicitly, as cmake will initialize it to the correct default. If the toolchain file from open embedded in general contains ASFLGS, cmake wills et that as CMAKE_AS_FLAGS automatically and pass those parameters on.
This variable did not change this behaviour because it was spelt differently, although I assume the author intended to do that.
I would still suggest removing this variable. (as this patch does)
[-- Attachment #2: Type: text/html, Size: 569 bytes --]
next prev parent reply other threads:[~2022-07-18 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 15:38 [PATCH] cmake: read asm flags correctly from environment in toolchain file Martin Beeger
2022-02-14 15:43 ` [OE-core] " Richard Purdie
2022-02-14 16:32 ` Martin Beeger
2022-02-15 14:18 ` Peter Kjellerstedt
2022-02-15 20:25 ` Martin Beeger
2022-07-18 16:47 ` Martin Beeger [this message]
2022-07-18 16:48 ` Martin Beeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22536.1658162830175506094@lists.openembedded.org \
--to=martin.beeger@online.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox