Re: [OE-core] [meta-oe][PATCH] libva: Removed virtual/mesa dependency

["Bartłomiej Burdukiewicz" <bartlomiej.burdukiewicz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3327 bytes --]

On Sun, 26 Apr 2020 06:23:57 CEST Anuj Mittal wrote:
> On Sat, 2020-04-25 at 12:38 -0700, Bartłomiej Burdukiewicz wrote:
> 
> > On Sat, Apr 25, 2020 at 06:46 AM, Khem Raj wrote:
> > 
> > 
> > > On 4/24/20 8:01 AM, Bartłomiej Burdukiewicz wrote: > Mesa can be
> > > compiled with libva support, in order to avoid recursive >
> > > dependency between mesa and libva, virtual/mesa must be removed >
> > > from libva recipe. > > Signed-off-by: Bartłomiej Burdukiewicz
> > > bartlomiej.burdukiewicz@gmail.com > --- > meta/recipes-
> > > graphics/libva/libva_2.6.1.bb | 2 +- > 1 file changed, 1
> > > insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-
> > > graphics/libva/libva_2.6.1.bb b/meta/recipes-
> > > graphics/libva/libva_2.6.1.bb > index 92cea83bc1..c1a441a18b 100644
> > > 
> > > > --- a/meta/recipes-graphics/libva/libva_2.6.1.bb > +++
> > > 
> > > b/meta/recipes-graphics/libva/libva_2.6.1.bb > @@ -23,7 +23,7 @@
> > > SRC_URI[sha256sum] =
> > > "6c57eb642d828af2411aa38f55dc10111e8c98976dbab8fd62e4862940 > >
> > > UPSTREAM_CHECK_URI = "https://github.com/intel/libva/releases" > >
> > > -DEPENDS = "libdrm virtual/mesa" > +DEPENDS = "libdrm"
> > > 
> > > I am not sure how it will work with non-mesa graphics stacks. Or is
> > > it non-issue ?
> > > 
> > 
> > 
> > It looks like libva is designed to work without mesa (or other
> > graphical stacks), since it's using libdrm to dispatch kernel calls. 
> > https://en.wikipedia.org/wiki/Direct_Rendering_Manager#/media/File:DRM_arc
> > hitecture.svg
 
> > There is also ebuild in Gentoo for libva do not depend on mesa (
> > https://data.gpo.zugaina.org/gentoo/x11-libs/libva/libva-2.6.1.ebuild
> > ) or other graphical stacks (like nvidia-drivers or etc.).
> 
> 
> I see a DEPEND on opengl there which is what glx backend in libva
> expects:
> 
> https://github.com/intel/libva/blob/master/meson.build#L95
> 
> Just removing the dependency will force glx backend to not be built. Is
> there software out there that expects libva-glx to be present?
> 
> Thanks,
> 
> Anuj

Sorry I was incorrect on Gentoo ebuild it's pulling virtual/opengl which is 
mesa (this is also for building libva-glx). I check what is pulling libva glx 
for Gentoo:

https://pastebin.com/bzppfKSz

For short: 

xine-lib - which is outdated,
qmplay2 - https://github.com/zaps166/QMPlay2#va-api--opengl-information
kodi - libva (with glx) is required for every display backed (wayland/gbm/X11) 
which is strange to me, this is probably lazy approach. I was able to run 
libva with kodi in gbm context without glx, not sure about X11 sessions.
mythtv - https://www.mythtv.org/wiki/VAAPI unclear

Other media player don't have strong requirements for GLX.

I'm now totally unsure. Probably adding PACKAGECONFIG with glx flag (disabled 
by default) will be better approach with conditional virtual/mesa dependency. 
This will fix recursive dependency problem for common cases. There is also ton 
of articles that GLX is deprecated, so softly going away should be a proper 
way.

Or just those bbappends should stay where they are. Another thing is that 
meta-intel layer introduced libva-intel package which also need separate 
bbappend to remove virtual/mesa, this made me to post that patch in first 
place.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 499 bytes --]