Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Diego Rondini <diego.rondini@kynetics.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/4] wic: fix restoring of original fstab
Date: Tue, 20 Jun 2017 10:27:42 +0200	[thread overview]
Message-ID: <2269926.uz0A4b8jSC@localhost.localdomain> (raw)

Hi Ed,

> Wic updates fstab if mount points are specified in .wks.
> After partition images are created the original fstab is restored.
> However, if exception is raised when partition image being prepared
> wic doesn't restore original fstab. This can cause duplication of
> added lines in fstab when 'wic create' runs next time.
> 
> Wrapping call of 'prepare' method and restoring original fstab
> even if exception occurs should fix this.
> 
> [YOCTO #11633]
> 
> Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>

I've applied the patch locally, and deliberately caused some WicError 
exceptions: the resulting fstab correctly has only one mount entry. So this 
seems to fix #11633.

Tested-by: Diego Rondini <diego.rondini@kynetics.com>

Thanks for taking care of this,
Diego


             reply	other threads:[~2017-06-20  8:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20  8:27 Diego Rondini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-06-16 13:19 [PATCH 0/4] wic: fix for #11633 and code cleanup Ed Bartosh
2017-06-16 13:19 ` [PATCH 4/4] wic: fix restoring of original fstab Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2269926.uz0A4b8jSC@localhost.localdomain \
    --to=diego.rondini@kynetics.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox