Re: [PATCH] Support kmeta directory usage with devtool modify/finish

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Saturday, 15 December 2018 1:39:22 PM NZDT Jaewon Lee wrote:
> When using Kmeta directories, devtool finish will add every single file
> in the directory to the bbappend. This is because in the current
> implementation, the get_recipe_local_files function treats the kmeta
> directory like a file. Modifying the function to loop through the
> provided directories and return all included files instead of just the
> top level directory. This will enable correct file to file comparison
> when determing which files are new/changed and need to be added to the
> bbappend.
> 
> Adding an extra check in devtool-source.bbclass to not copy the cfg file
> if its already included somewhere in the kmeta directory
> 
> Also during 'modify', when moving necessary files in the kmeta directory
> from the workdir to oe-local-files, the dangling parent directories are
> left behind.  This in itself is not an issue as the temporary devtool
> workspace is automatically deleted, but this causes an incorrect include
> directory to be added in kernel-yocto.bbclass.  Changing the order of
> the if statements to catch the correct conditional. This is safe to do
> as when not in the devtool context, there will be no oe-local-files
> directory.

Looks good to me. My apologies for the extreme delay in reviewing.

Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>


-- 

Paul Eggleton
Intel Open Source Technology Centre