Re: [PATCH] systemd: Remove init.d dir if systemd unit file is present and sysvinit not a distro feature

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Wednesday 24 July 2013 18:22:11 Muhammad Shakeel wrote:
> On 07/23/2013 03:46 PM, Enrico Scholz wrote:
> > "Shakeel, Muhammad"
> > 
> > <muhammad_shakeel-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org> writes:
> >> If systemd is supported DISTRO_FEATURE and sysvinit is not and also if
> >> systemd_unitdir contains a service file(s) then no need to keep init.d
> >> scripts for sysvinit compatibility.
> >> ...
> >> +            for filename in os.listdir(systemd_unitdir):
> > 
> >> +                if filename.endswith(".service"):
> > why only .service?  Other systemd files (.socket, .mount, .path, ...)
> > can also replace initscripts.
> 
> Other systemd unit files are normally accompanied with a .service file
> (this is just I observed and not mandatory).
> 
> If we come across any package which is not providing .service file but
> only some other type of systemd unit file for initscripts replacement
> then we can always add check for that type.
> According to systemd documentation there can be 10 types of systemd unit
> files and checking for all here can be a little overhead.

Would it work to simply check for any files instaled into systemd_unitdir?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre