Re: [PATCH 4/4] packagegroup-core-boot: used udev-cache for sysvinit

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Thursday 27 June 2013 15:43:17 Saul Wold wrote:
> Enabling this by default since it does improve boot time when using sysvinit
> udev
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb index
> d69c41d..1e1ee8e 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> @@ -43,6 +43,7 @@ RDEPENDS_${PN} = "\
>      ${VIRTUAL-RUNTIME_init_manager} \
>      ${VIRTUAL-RUNTIME_initscripts} \
>      ${VIRTUAL-RUNTIME_dev_manager} \
> +    ${@base_contains("DISTRO_FEATURES", "systemd", "", "udev-cache", d)} \
>      ${VIRTUAL-RUNTIME_update-alternatives} \
>      ${MACHINE_ESSENTIAL_EXTRA_RDEPENDS}"

I appreciate the intention here but I'm not sure if this is really the 
appropriate place to put this; packagegroup-core-boot is supposed to only 
directly pull in the essentials required for booting. This will cause problems 
for those people using alternative device managers (e.g. busybox mdev) as 
well.

I'm not sure where this should go, but adding it to VIRTUAL-
RUNTIME_dev_manager (in the distro config?) could work. Anyone else have any 
better suggestion?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre