From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B292D7877D for ; Fri, 19 Dec 2025 13:57:00 +0000 (UTC) Subject: Re: [PATCH 1/1] wpa-supplicant: fix sed expression To: openembedded-core@lists.openembedded.org From: vishal.gupta_1@philips.com X-Originating-Location: =?UTF-8?B?RMO8c3NlbGRvcmYsIE5vcnRoIFJoaW5lLVdlc3RwaGFsaWEsIERF?= (155.190.62.28) X-Originating-Platform: Windows Edge 143 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 19 Dec 2025 05:56:55 -0800 References: <20251219124928.1474117-1-vishal.gupta_1@bbl.philips.com> In-Reply-To: Message-ID: <250823.1766152615641090465@lists.openembedded.org> Content-Type: multipart/alternative; boundary="CTXmTiexHfgxYjeSMTXs" List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 19 Dec 2025 13:57:00 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/228238 --CTXmTiexHfgxYjeSMTXs Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Alexander, In the do_configure function current intention of implementation is to firs= t delete it when we copying and then depending on the PACKAGECONFIG assign = it with correct value. As delete is failed because the line start with "#" we will have two CONFIG= _TLS value in final ".config" file one, at some where middle of the file #CONFIG_TLS=3Dopenssl second, depending on package config, at the end of file as it's an append o= peration. CONFIG_TLS=3Dopenssl / gnutls do_configure () { ${MAKE} -C wpa_supplicant clean sed -e '/^#\?CONFIG_TLS=3D/d' wpa_supplicant/.co= nfig if ${@ bb.utils.contains('PACKAGECONFIG', 'openssl', 'true', 'false', d) };= then echo 'CONFIG_TLS=3Dopenssl' >>wpa_supplicant/.config elif ${@ bb.utils.contains('PACKAGECONFIG', 'gnutls', 'true', 'false', d) }= ; then echo 'CONFIG_TLS=3Dgnutls' >>wpa_supplicant/.config sed -i -e 's/\(^CONFIG_DPP=3D\)/#\1/' \ -e 's/\(^CONFIG_EAP_PWD=3D\)/#\1/' \ -e 's/\(^CONFIG_SAE=3D\)/#\1/' wpa_supplicant/.config fi So with this change there will be only one "CONFIG_TLS=3D" option. --CTXmTiexHfgxYjeSMTXs Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Hi Alexander,

In t= he do_configure function current intention of implementation is to first de= lete it when we copying and then depending on the PACKAGECONFIG assign it w= ith correct value.
As delete is failed because the line = start with "#" we will have two CONFIG_TLS value in final ".config" file

one, at some where middle of the file
#CONFIG_TLS=3D= openssl
=
second, depending on package config, at the end of file as it'= s an append operation.
CONFIG_TLS=3Dopenssl / gnutls

do_configure () {
        ${MAKE= } -C wpa_supplicant clean
        se= d -e '/^#\?CONFIG_TLS=3D/d' <wpa_supplicant/defconfig >wpa_supplicant= /.config
        if ${@ bb.utils.con= tains('PACKAGECONFIG', 'openssl', 'true', 'false', d) }; then
                echo 'CONFIG_= TLS=3Dopenssl' >>wpa_supplicant/.config
  &nb= sp;     elif ${@ bb.utils.contains('PACKAGECONFIG', 'gnutls', 'tr= ue', 'false', d) }; then
        &nb= sp;       echo 'CONFIG_TLS=3Dgnutls' >>wpa_supplicant/= .config
=              =   sed -i -e 's/\(^CONFIG_DPP=3D\)/#\1/' \
  &= nbsp;                 -e 's/\(^CONF= IG_EAP_PWD=3D\)/#\1/' \
        &nbs= p;           -e 's/\(^CONFIG_SAE=3D\)/#\1/' wpa_su= pplicant/.config
        fi

So with this change there will be only one "CONFIG_TLS=3D&= lt;value>" option.
--CTXmTiexHfgxYjeSMTXs--