Re: [OE-core] [PATCH 1/6] linux-yocto-dev: conditionally add coreutils to depends

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Bruce,

On 10/14/24 3:45 PM, Bruce Ashfield via lists.openembedded.org wrote:
> From: Bruce Ashfield <bruce.ashfield@gmail.com>
> 
> 6.11+ uses truncate as part of the build. While truncate has been
> added to HOSTTOOLS in oe-core master, it still is possible to
> build a kernel recipe newer than 6.11+ on a release that doesn't
> have the HOSTTOOLS tweak.
> 
> We can test for truncate and condtionally add the dependency.
> 
> Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
> ---
>   meta/recipes-kernel/linux/linux-yocto-dev.bb | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-kernel/linux/linux-yocto-dev.bb b/meta/recipes-kernel/linux/linux-yocto-dev.bb
> index 292897ce43..752d108bd8 100644
> --- a/meta/recipes-kernel/linux/linux-yocto-dev.bb
> +++ b/meta/recipes-kernel/linux/linux-yocto-dev.bb
> @@ -44,6 +44,10 @@ PACKAGECONFIG[dt-validation] = ",,python3-dtschema-native"
>   # we need the wrappers if validation isn't in the packageconfig
>   DEPENDS += "${@bb.utils.contains('PACKAGECONFIG', 'dt-validation', '', 'python3-dtschema-wrapper-native', d)}"
>   
> +# 6.11+ uses truncate in the build, so we need to either have it in host tools, or
> +# build it ourselves
> +DEPENDS += "${@bb.utils.contains('HOSTTOOLS', 'truncate', '', 'coreutils-native', d)}"
> +

Nice :)

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

For the sake of completeness, truncate is part of HOSTTOOLS in 
scarthgap-5.0.5+ (yes, not released yet) and styhead and later releases. 
We may want to backport this HOSTTOOLS+truncate patch to kirkstone as 
well maybe? So this patch here is only required for any other scenario 
:) (it's basically not useful for master branch but is nice as a hint to 
user trying to figure out how to compile 6.11 on other branches :) ).

Thanks!
Quentin