Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Martin Siegumfeldt" <mns@gomspace.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] systemd.bbclass: generate preset for templates
Date: Sun, 01 Jun 2025 12:49:52 -0700	[thread overview]
Message-ID: <26404.1748807392945644245@lists.openembedded.org> (raw)
In-Reply-To: <20250529174427.2731440-1-patrick@stwcx.xyz>

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

On Thu, May 29, 2025 at 10:44 AM, Patrick Williams wrote:

> 
> There was a regression introduced by the change to use
> systemd-systemctl-native rather than a python fake implementation,
> which caused template units to not be properly enabled when set in
> the SYSTEMD_SERVICE variable. Through investigation, it seems that
> the best way to re-enable template instances is to handle them
> explicitly in the systemd.bbclass and enable them with `preset`, like
> most units are handled[1,2].
> 
> Per the systemd.preset manpage, the format for template units is
> different than for regular units[3]. We need to coalesce all the
> template instances onto a single line and emit them as an additional
> space-deliminated argument.
> 
> Ran this against openbmc's phosphor-ipmi-net recipe and generated
> the following preset file:
> ```
> $ cat
> packages-split/phosphor-ipmi-net/usr/lib/systemd/system-preset/98-phosphor-ipmi-net.preset
> 
> enable phosphor-ipmi-net@.service eth0
> enable phosphor-ipmi-net@.socket eth0
> ```

Thanks again Patrick for looking into this. I can confirm that the patch resolves the issue I encountered - hoping for it to be backported to Walnascar after merge.

Martin

[-- Attachment #2: Type: text/html, Size: 1330 bytes --]

      reply	other threads:[~2025-06-01 19:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29 17:44 [PATCH v2] systemd.bbclass: generate preset for templates Patrick Williams
2025-06-01 19:49 ` Martin Siegumfeldt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26404.1748807392945644245@lists.openembedded.org \
    --to=mns@gomspace.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox