Re: [OE-core] [RFC 1/5] valgrind: make ptest depend on all components

[Yash Shinde <Yash.Shinde@windriver.com>]

On 21-11-2023 21:27, Alex Kiernan wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Tue, Nov 21, 2023 at 11:30 AM Yash Shinde <Yash.Shinde@windriver.com> wrote:
>>
>> On 20-11-2023 21:57, Alex Kiernan wrote:
>>> CAUTION: This email comes from a non Wind River email account!
>>> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>>>
>>> I've finally got this running in a way I can usefully inspect and try
>>> things and it's beginning to feel like we've headed into something
>>> which simply isn't supported.
>>>
>>> The failure is this:
>>>
>>>     thread 'main' panicked at src/tools/compiletest/src/common.rs:519:30:
>>>     no entry found for key
>>>
>>> Which is empty because the mapping list is collected by running rustc
>>> with -Z unstable-options --print=all-target-specs-json, but that fails
>>> because we're not running a nightly compiler:
>>>
>>>     error: the option `Z` is only accepted on the nightly compiler
>>>     help: consider switching to a nightly toolchain: `rustup default nightly`
>>>     note: selecting a toolchain with `+toolchain` arguments require a
>>> rustup proxy; see
>>> <https://rust-lang.github.io/rustup/concepts/index.html>
>>>     note: for more information about Rust's stability policy, see
>>> <https://doc.rust-lang.org/book/appendix-07-nightly-rust.html#unstable-features>
>>>
>>> Basically feels like running the test suite is only supported on the
>>> nightlies...
>> I saw the same error earlier.
>>
>> Investigating further, we understood that the issue is not related to
>> running on nightly channel. The '-Z unstable options' were also present
>> in earlier rust versions and removing of the newly added -Z options
>> after 1.70 also didn't solve the problem.
>>
> There's a fair number of changes in the test framework around the code
> that calls out to rustc with new paths that use
> --print=all-target-specs-json unconditionally. Assuming I've read it
> right, -Zunstable-options is only evaluated at the point where you
> actually try and use such an option which is covered by
> unstable-options, so just passing it in doesn't get you a failure.
>
>> On doing further analysis, we found that the custom target config/specs
>> were not fetched during the rust build.
>>
>> The log for reference is as follows:
>>
>> Building stage1 library artifacts (x86_64-unknown-linux-gnu ->
>> x86_64-poky-linux-gnu)
>> error: failed to run `rustc` to learn about target-specific information
>>
>> Caused by:
>>     process didn't exit successfully: `
>> build-st/tmp/work/core2-64-poky-linux/rust/1.72.0/rustc-1.72.0-src/build/bootstrap/debug/rustc
>> - --crate-name ___ --print=file-names -Csymbol-mangling-version=legacy
>> -Zunstable-options -Zunstable-options '--check-cfg=values(bootstrap)'
>> '--check-cfg=values(stdarch_intel_sde)'
>> '--check-cfg=values(no_fp_fmt_parse)'
>> '--check-cfg=values(no_global_oom_handling)' '--check-cfg=values(no_rc)'
>> '--check-cfg=values(no_sync)' '--check-cfg=values(freebsd12)'
>> '--check-cfg=values(freebsd13)'
>> '--check-cfg=values(backtrace_in_libstd)'
>> '--check-cfg=values(target_env,"libnx")'
>> '--check-cfg=values(target_arch,"asmjs","spirv","nvptx","xtensa")'
>> -Zmacro-backtrace -Clink-args=-Wl,-z,origin
>> '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Csplit-debuginfo=off
>> -Cprefer-dynamic -Zinline-mir -Cembed-bitcode=yes
>> '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/1.72.0/")'
>> --target x86_64-poky-linux-gnu --crate-type bin --crate-type rlib
>> --crate-type dylib --crate-type cdylib --crate-type staticlib
>> --crate-type proc-macro --print=sysroot --print=split-debuginfo
>> --print=crate-name --print=cfg` (exit status: 1)
>>     --- stderr
>>     error: Error loading target specification: Could not find
>> specification for target "x86_64-poky-linux-gnu". Run `rustc --print
>> target-list` for a list of built-in targets
>>
> Out of interest, did you try 1.71.0 to see if that failed? Based on
> reading the commit log for src/tools/compiletest/src/common.rs, I
> suspect it will fail.
>
Yes, that fails in 1.71.0 also. The 1.71 build progresses to check some 
test suites before failing as follows-

.........Test cases running from different suites like codegen, ui, 
mir-opt, assembly, incremental....

test [incremental] 
tests/incremental/issue-79661-missing-def-path-hash.rs ... ok
test [incremental] tests/incremental/remapped_paths_cc/main.rs ... ok
test [incremental] tests/incremental/lto.rs ... ok
test result: ok. 161 passed; 0 failed; 2 ignored; 0 measured; 0 filtered 
out; finished in 12.51s
finished in 13.102 seconds
Check compiletest suite=debuginfo mode=debuginfo 
(x86_64-unknown-linux-gnu -> x86_64-poky-linux-gnu)
WARNING: debuginfo tests are not available when testing with remote
running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered 
out; finished in 18.92µs

         finished in 0.147 seconds

Building stage0 library artifacts (x86_64-poky-linux-gnu)
error: process didn't exit successfully: 
`build-st/tmp/work/core2-64-poky-linux/rust/1.71.0/rustc-1.71.0-src/build/bootstrap/debug/rustc 
-vV` (exit status: 101)
--- stderr
thread 'main' panicked at '
Failed to run:
LD_LIBRARY_PATH="/build-st/tmp/work/core2-64-poky-linux/rust/1.71.0/rustc-1.71.0-src/build/x86_64-poky-linux-gnu/stage0-sysroot/lib" 
"build-st/tmp/work/core2-64-poky-linux/rust/1.71.0/rustc-1.71.0-src/build/x86_64-poky-linux-gnu/stage0-sysroot/bin/rustc" 
"-vV" "-Wrust_2018_idioms" "-Wunused_lifetimes" 
"-Wsemicolon_in_expressions_from_macros" "-Dwarnings" 
"-Clinker=build-st/tmp/work/core2-64-poky-linux/rust/1.71.0/wrapper/target-rust-ccld" 
"--cfg=bootstrap" "-Zunstable-options" "--check-cfg=values(bootstrap)" 
"-Z" "force-unstable-if-unmarked"
-------------: Os { code: 2, kind: NotFound, message: "No such file or 
directory" }', bin/rustc.rs:230:37
note: run with `RUST_BACKTRACE=1` environment variable to display a 
backtrace

Build completed unsuccessfully in 0:06:09

Regards,
Yash
> --
> Alex Kiernan