From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mail.openembedded.org (Postfix) with ESMTP id 3A6456A598 for ; Wed, 5 Jun 2013 17:05:23 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 05 Jun 2013 10:04:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,808,1363158000"; d="scan'208";a="348619160" Received: from unknown (HELO helios.localnet) ([10.252.121.228]) by fmsmga002.fm.intel.com with ESMTP; 05 Jun 2013 10:04:35 -0700 From: Paul Eggleton To: openembedded-core@lists.openembedded.org Date: Wed, 05 Jun 2013 18:04:34 +0100 Message-ID: <2653566.bBSFCXsGIZ@helios> Organization: Intel Corporation User-Agent: KMail/4.10.2 (Linux/3.8.0-23-generic; KDE/4.10.2; i686; ; ) In-Reply-To: <2054363.UxqkIOrzAJ@helios> References: <1370422910-24366-1-git-send-email-net147@gmail.com> <51AF6B79.3040506@linux.intel.com> <2054363.UxqkIOrzAJ@helios> MIME-Version: 1.0 Subject: Re: [PATCH] qmake2.bbclass: export OE_QMAKE_QT_CONFIG X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2013 17:05:23 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Wednesday 05 June 2013 17:57:32 Paul Eggleton wrote: > On Wednesday 05 June 2013 09:46:49 Saul Wold wrote: > > On 06/05/2013 02:30 AM, Martin Jansa wrote: > > > On Wed, Jun 05, 2013 at 07:01:50PM +1000, Jonathan Liu wrote: > > >> qconfig.pri was not being loaded by qmake properly. This means Qt > > >> qmake projects are unable to query QT_ARCH, QT_VERSION and other > > >> variables defined in qconfig.pri. > > >> > > >> Export OE_QMAKE_QT_CONFIG, setting it to the location of qconfig.pri > > >> so that it can be located by qmake. > > > > > > There is such patch already: > > > http://lists.openembedded.org/pipermail/openembedded-core/2013-May/07831 > > > 4. > > > html > > > > Got lost in my queue, adding it for the next MUT. > > FWIW I am still concerned by the assertion in the commit message about it > causing undesirable behaviour. I'd want that checked out and the note > removed before we look at merging this. (I mean undesirable behaviour on rebuild after applying this patch; I should mention I'm testing this at the moment.) Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre