Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] buildhistory: remove duplicate entries from dot graph
Date: Tue, 20 Mar 2012 13:14:28 +0000	[thread overview]
Message-ID: <27193241.TpUGZafhRb@helios> (raw)
In-Reply-To: <C78FED4E-E3C7-4369-9622-0A4C6AA009DC@dominion.thruhere.net>

On Tuesday 20 March 2012 13:11:38 Koen Kooi wrote:
> I think I know why [2] doesn't work:
> 
> koen@dominion:/data/ssd/OE/buildhistory$ echo b c a | sort
> b c a
> koen@dominion:/data/ssd/OE/buildhistory$ echo -e b\\nc\\na | sort
> a
> b
> c

Ah, yes, that would explain it. I've primarily been testing with rpm for which 
list_package_depends produces the output on separate lines, whereas the ipk 
version is all on one line; it only matters when doing the sort. Oops!

> Let me know how you want me to respin this series, each commit is an RFC on
> its own.

If you wouldn't mind I think the easiest thing is to drop the sort/uniq on the 
depends/recommends and just rely on the one at the end that you're adding. It 
does mean we'll have a one-time resort of the recommends and depends together 
but at least it will work properly for all package backends.

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2012-03-20 13:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20 11:00 [PATCH 1/3] buildhistory: record all builds Koen Kooi
2012-03-20 11:00 ` [PATCH 2/3] buildhistory: make seperate commits for every entry in the buildhistory dir Koen Kooi
2012-03-20 11:00 ` [PATCH 3/3] buildhistory: remove duplicate entries from dot graph Koen Kooi
2012-03-20 11:48   ` Paul Eggleton
2012-03-20 12:11     ` Koen Kooi
2012-03-20 13:14       ` Paul Eggleton [this message]
2012-03-20 13:40         ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27193241.TpUGZafhRb@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox