* [OE-core][PATCH 1/2] systemd: do not let do_fetch depend on PACKAGECONFIG
@ 2026-01-15 2:19 Qi.Chen
2026-01-15 2:19 ` [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG Qi.Chen
0 siblings, 1 reply; 7+ messages in thread
From: Qi.Chen @ 2026-01-15 2:19 UTC (permalink / raw)
To: openembedded-core
From: Chen Qi <Qi.Chen@windriver.com>
It's unnecessary to make SRC_URI contains something like:
${@bb.utils.contains('PACKAGECONFIG', 'xxx', 'file://xxx', '', d)}
This does not give us any benefit and it makes do_fetch depend
on PACKAGECONFIG, which means changing of PACKAGECONFIG will result
in rerunn of do_fetch.
Besides, the related codes in do_install already does the necessary
checks.
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
meta/recipes-core/systemd/systemd_258.1.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/systemd/systemd_258.1.bb b/meta/recipes-core/systemd/systemd_258.1.bb
index 410396f308..41f1e756cb 100644
--- a/meta/recipes-core/systemd/systemd_258.1.bb
+++ b/meta/recipes-core/systemd/systemd_258.1.bb
@@ -21,8 +21,8 @@ REQUIRED_DISTRO_FEATURES += "systemd"
SRC_URI += " \
file://touchscreen.rules \
file://00-create-volatile.conf \
- ${@bb.utils.contains('PACKAGECONFIG', 'polkit_hostnamed_fallback', 'file://org.freedesktop.hostname1_no_polkit.conf', '', d)} \
- ${@bb.utils.contains('PACKAGECONFIG', 'polkit_hostnamed_fallback', 'file://00-hostnamed-network-user.conf', '', d)} \
+ file://org.freedesktop.hostname1_no_polkit.conf \
+ file://00-hostnamed-network-user.conf \
file://init \
file://99-default.preset \
file://systemd-pager.sh \
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG
2026-01-15 2:19 [OE-core][PATCH 1/2] systemd: do not let do_fetch depend on PACKAGECONFIG Qi.Chen
@ 2026-01-15 2:19 ` Qi.Chen
2026-01-23 13:06 ` Paul Barker
2026-01-26 12:54 ` [OE-core][PATCH " Ross Burton
0 siblings, 2 replies; 7+ messages in thread
From: Qi.Chen @ 2026-01-15 2:19 UTC (permalink / raw)
To: openembedded-core
From: Chen Qi <Qi.Chen@windriver.com>
New version of systemd introduces dropins in /etc/profile.d. This
is usually OK for most cases. But in case of using minicom to connect
to the machine, there will be unnecessary output every time you type
a command.
This is because the /etc/profile.d/80-systemd-osc-context.sh[1] is setting
PS0 with OSC 3008 standard[2]. If a terminal (e.g., minicom) cannot
deal with this OSC 3008 standard, it will just output the whole contents.
This is quite annoying.
So add a new PACKAGECONFIG, shell-profile-dropins, to allow users a choice
to disable such behavior.
[1] https://github.com/systemd/systemd/commit/dadbb34919abd3fefeb5b8ccc9794da9398a2503
[2] https://uapi-group.org/specifications/specs/osc_context/
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
meta/recipes-core/systemd/systemd_258.1.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-core/systemd/systemd_258.1.bb b/meta/recipes-core/systemd/systemd_258.1.bb
index 41f1e756cb..7c6f6c65dd 100644
--- a/meta/recipes-core/systemd/systemd_258.1.bb
+++ b/meta/recipes-core/systemd/systemd_258.1.bb
@@ -84,6 +84,7 @@ PACKAGECONFIG ??= " \
resolved \
serial-getty-generator \
set-time-epoch \
+ shell-profile-dropins \
sysusers \
timedated \
timesyncd \
@@ -197,6 +198,7 @@ PACKAGECONFIG[resolved] = "-Dresolve=true,-Dresolve=false"
PACKAGECONFIG[rfkill] = "-Drfkill=true,-Drfkill=false"
PACKAGECONFIG[seccomp] = "-Dseccomp=enabled,-Dseccomp=disabled,libseccomp"
PACKAGECONFIG[selinux] = "-Dselinux=enabled,-Dselinux=disabled,libselinux,initscripts-sushell"
+PACKAGECONFIG[shell-profile-dropins] = ",-Dshellprofiledir=no"
PACKAGECONFIG[smack] = "-Dsmack=true,-Dsmack=false"
PACKAGECONFIG[sysext] = "-Dsysext=true, -Dsysext=false"
PACKAGECONFIG[sysusers] = "-Dsysusers=true,-Dsysusers=false"
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG
2026-01-15 2:19 ` [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG Qi.Chen
@ 2026-01-23 13:06 ` Paul Barker
2026-01-28 2:47 ` ChenQi
2026-01-26 12:54 ` [OE-core][PATCH " Ross Burton
1 sibling, 1 reply; 7+ messages in thread
From: Paul Barker @ 2026-01-23 13:06 UTC (permalink / raw)
To: Qi.Chen, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]
On Thu, 2026-01-15 at 10:19 +0800, Chen Qi via lists.openembedded.org
wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> New version of systemd introduces dropins in /etc/profile.d. This
> is usually OK for most cases. But in case of using minicom to connect
> to the machine, there will be unnecessary output every time you type
> a command.
>
> This is because the /etc/profile.d/80-systemd-osc-context.sh[1] is setting
> PS0 with OSC 3008 standard[2]. If a terminal (e.g., minicom) cannot
> deal with this OSC 3008 standard, it will just output the whole contents.
> This is quite annoying.
>
> So add a new PACKAGECONFIG, shell-profile-dropins, to allow users a choice
> to disable such behavior.
>
> [1] https://github.com/systemd/systemd/commit/dadbb34919abd3fefeb5b8ccc9794da9398a2503
> [2] https://uapi-group.org/specifications/specs/osc_context/
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Qi,
There may be other files in profile.d as well as
80-systemd-osc-context.sh. In systemd 258.x, I also see
70-systemd-shell-extra.sh. I don't think we should offer the option of
disabling install of all systemd profile.d files in order to fix
incompatibility with just one of them.
There have been changes to 80-systemd-osc-context.sh in systemd 259. We
could try backporting 705e2ef19418 ("profile/osc-context: move and
extend check for TERM=dumb") if we're not ready to update to 259 yet and
see if that resolves the issue. We may also need dd20ba74e3b4
("profile/systemd-osc-context: fix overriding of PROMPT_COMMAND") and
97ad10c9aab1 ("profile: skip setting PS0 when PROMPT_COMMAND= is
cleared"), I'm not sure.
Best regards,
--
Paul Barker
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG
2026-01-23 13:06 ` Paul Barker
@ 2026-01-28 2:47 ` ChenQi
2026-04-05 14:04 ` [PATCH " Martin Siegumfeldt
0 siblings, 1 reply; 7+ messages in thread
From: ChenQi @ 2026-01-28 2:47 UTC (permalink / raw)
To: Paul Barker, openembedded-core
On 1/23/26 21:06, Paul Barker wrote:
> On Thu, 2026-01-15 at 10:19 +0800, Chen Qi via lists.openembedded.org
> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> New version of systemd introduces dropins in /etc/profile.d. This
>> is usually OK for most cases. But in case of using minicom to connect
>> to the machine, there will be unnecessary output every time you type
>> a command.
>>
>> This is because the /etc/profile.d/80-systemd-osc-context.sh[1] is setting
>> PS0 with OSC 3008 standard[2]. If a terminal (e.g., minicom) cannot
>> deal with this OSC 3008 standard, it will just output the whole contents.
>> This is quite annoying.
>>
>> So add a new PACKAGECONFIG, shell-profile-dropins, to allow users a choice
>> to disable such behavior.
>>
>> [1] https://github.com/systemd/systemd/commit/dadbb34919abd3fefeb5b8ccc9794da9398a2503
>> [2] https://uapi-group.org/specifications/specs/osc_context/
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> Qi,
>
> There may be other files in profile.d as well as
> 80-systemd-osc-context.sh. In systemd 258.x, I also see
> 70-systemd-shell-extra.sh. I don't think we should offer the option of
> disabling install of all systemd profile.d files in order to fix
> incompatibility with just one of them.
>
> There have been changes to 80-systemd-osc-context.sh in systemd 259. We
> could try backporting 705e2ef19418 ("profile/osc-context: move and
> extend check for TERM=dumb") if we're not ready to update to 259 yet and
> see if that resolves the issue. We may also need dd20ba74e3b4
> ("profile/systemd-osc-context: fix overriding of PROMPT_COMMAND") and
> 97ad10c9aab1 ("profile: skip setting PS0 when PROMPT_COMMAND= is
> cleared"), I'm not sure.
>
> Best regards, i
>
Hi Paul,
Thanks for checking upstream status.
I think you're right. The commits you mentioned above are likely to fix
the issue.
I'll double check when upgrading systemd to 259.x.
Regards,
Qi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG
2026-01-15 2:19 ` [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG Qi.Chen
2026-01-23 13:06 ` Paul Barker
@ 2026-01-26 12:54 ` Ross Burton
2026-01-27 9:09 ` Chen, Qi
1 sibling, 1 reply; 7+ messages in thread
From: Ross Burton @ 2026-01-26 12:54 UTC (permalink / raw)
To: Qi.Chen@windriver.com; +Cc: openembedded-core@lists.openembedded.org
On 15 Jan 2026, at 02:19, Chen Qi via lists.openembedded.org <Qi.Chen=windriver.com@lists.openembedded.org> wrote:
>
> +PACKAGECONFIG[shell-profile-dropins] = ",-Dshellprofiledir=no”
On top of what Paul said, we always want to be specific and not make assumptions when enabling/disabling PACKAGECONFIGS, so the “enabled” case should have been -Dshellprofiledir=${sysconfigdir}/profile.d.
Ross
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG
2026-01-26 12:54 ` [OE-core][PATCH " Ross Burton
@ 2026-01-27 9:09 ` Chen, Qi
0 siblings, 0 replies; 7+ messages in thread
From: Chen, Qi @ 2026-01-27 9:09 UTC (permalink / raw)
To: ross.burton@arm.com; +Cc: openembedded-core@lists.openembedded.org, Paul Barker
Hi Ross,
Thanks for the review. I'll fix this and send out V2.
By the way, I didn't receive Paul's reply. If there's some other concern, please let me know.
Regards,
Qi
-----Original Message-----
From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Ross Burton via lists.openembedded.org
Sent: Monday, January 26, 2026 8:54 PM
To: Chen, Qi <Qi.Chen@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG
On 15 Jan 2026, at 02:19, Chen Qi via lists.openembedded.org <Qi.Chen=windriver.com@lists.openembedded.org> wrote:
>
> +PACKAGECONFIG[shell-profile-dropins] = ",-Dshellprofiledir=no”
On top of what Paul said, we always want to be specific and not make assumptions when enabling/disabling PACKAGECONFIGS, so the “enabled” case should have been -Dshellprofiledir=${sysconfigdir}/profile.d.
Ross
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-04-05 14:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-15 2:19 [OE-core][PATCH 1/2] systemd: do not let do_fetch depend on PACKAGECONFIG Qi.Chen
2026-01-15 2:19 ` [OE-core][PATCH 2/2] systemd: add shell-profile-dropins PACKAGECONFIG Qi.Chen
2026-01-23 13:06 ` Paul Barker
2026-01-28 2:47 ` ChenQi
2026-04-05 14:04 ` [PATCH " Martin Siegumfeldt
2026-01-26 12:54 ` [OE-core][PATCH " Ross Burton
2026-01-27 9:09 ` Chen, Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox