Re: [PATCH 5/5] oe-setup-build: add a tool for discovering config templates and setting up builds

["Jermain Horsman" <jermain.horsman@nedap.com>]

I just tried to run the selftest on bblayers using oe-core and not poky and I noticed some failures,
which I thought I'd share.

>          # The revision-under-test may not necessarily be available on the
> remote server,
> -        # so replace it with a revision that has a yocto-4.0 tag.
> +        # so replace it with a revision that has a yocto-4.1 tag.
>          import json
>          with open(jsonfile) as f:
>              data = json.load(f)
>          for s in data['sources']:
> -            data['sources'][s]['git-remote']['rev'] =
> '00cfdde791a0176c134f31e5a09eff725e75b905'
> +            data['sources'][s]['git-remote']['rev'] =
> '5200799866b92259e855051112520006e1aaaac0'

First I got a failure here, as this is not a valid reference on oe-core, only on poky is this valid.

> +def setup_build_env(args):
> +    templates = discover_templates(args.layerlist)
> +    if not templates:
> +        return
> +
> +    template = find_template(args.c, templates)
> +    if not template:
> +        return
> +    builddir = args.b if args.b else template["buildpath"]
> +    no_shell = args.no_shell
> +    coredir =
> os.path.abspath(os.path.join(os.path.dirname(os.path.realpath(__file__)),
> '..'))
> +    cmd = "TEMPLATECONF={} . {} {}".format(template["templatepath"],
> os.path.join(coredir, 'oe-init-build-env'), builddir)
> +    if not no_shell:
> +        cmd = cmd + " && {}".format(os.environ['SHELL'])
> +    print("Running:", cmd)
> +    subprocess.run(cmd, shell=True, executable=os.environ['SHELL'])
> +

2024-02-08 13:14:26,793 - oe-selftest - INFO - ======================================================================
2024-02-08 13:14:26,793 - oe-selftest - INFO - FAIL: test_bitbakelayers_setup (bblayers.BitbakeLayers)
2024-02-08 13:14:26,794 - oe-selftest - INFO - ----------------------------------------------------------------------
2024-02-08 13:14:26,794 - oe-selftest - INFO - Traceback (most recent call last):
  File "/home/builder/workdir/openembedded-core-contrib/meta/lib/oeqa/selftest/cases/bblayers.py", line 189, in test_bitbakelayers_setup
    result = runCmd(cmd)
  File "/home/builder/workdir/openembedded-core-contrib/meta/lib/oeqa/utils/commands.py", line 212, in runCmd
    raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output))
AssertionError: Command '/home/builder/workdir/build-st/test-layer-checkout/setup-build --layerlist /home/builder/workdir/build-st/test-layer-checkout/.oe-layers.json setup -c meta-default --no-shell' returned non-zero exit status 1:
Available build configurations:

1. meta-default
This configuration does not have a description.

Re-run with 'list -v' to see additional information.
Running: TEMPLATECONF=/home/builder/workdir/build-st/test-layer-checkout/openembedded-core-contrib/meta/conf/templates/default . /home/builder/workdir/openembedded-core-contrib/oe-init-build-env /home/builder/workdir/build-st/build-meta-default
Traceback (most recent call last):
  File "/home/builder/workdir/build-st/test-layer-checkout/setup-build", line 119, in <module>
    args.func(args)
  File "/home/builder/workdir/build-st/test-layer-checkout/setup-build", line 98, in setup_build_env
    subprocess.run(cmd, shell=True, executable=os.environ['SHELL'])
  File "/usr/lib/python3.9/os.py", line 679, in __getitem__
    raise KeyError(key) from None
KeyError: 'SHELL'


I'm not entirely sure what was going on here, the SHELL variable was set in the shell environment, however it was not in os.environ.