From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mail.openembedded.org (Postfix) with ESMTP id 95B3D6D092 for ; Wed, 30 Oct 2013 15:42:29 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 30 Oct 2013 08:42:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,535,1378882800"; d="scan'208";a="401035342" Received: from unknown (HELO helios.localnet) ([10.252.120.230]) by orsmga001.jf.intel.com with ESMTP; 30 Oct 2013 08:42:30 -0700 From: Paul Eggleton To: Gary Thomas Date: Wed, 30 Oct 2013 15:42:30 +0000 Message-ID: <2838372.Sev3eZbt1S@helios> Organization: Intel Corporation User-Agent: KMail/4.10.5 (Linux/3.8.0-31-generic; KDE/4.10.5; i686; ; ) In-Reply-To: <52712859.6070002@mlbassoc.com> References: <5271162B.6020008@mlbassoc.com> <1953485.uklNZh2O8P@helios> <52712859.6070002@mlbassoc.com> MIME-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] core-image-basic.bb: Allow user extensions X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2013 15:42:29 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Wednesday 30 October 2013 09:40:09 Gary Thomas wrote: > On 2013-10-30 09:33, Paul Eggleton wrote: > > On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote: > >> On 2013-10-30 08:47, Paul Eggleton wrote: > >>> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote: > >>>> Allow the user to provide additional packages to this image. > >>>> This lets core-image-basic behave like all other core-image* > >>>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well > >>>> as match the documentation which suggests this as the mode to > >>>> extend any core-image* image. > >>>> > >>>> Signed-off-by: Gary Thomas > >>>> --- > >>>> > >>>> meta/recipes-extended/images/core-image-basic.bb | 3 +++ > >>>> 1 file changed, 3 insertions(+) > >>>> > >>>> diff --git a/meta/recipes-extended/images/core-image-basic.bb > >>>> b/meta/recipes-extended/images/core-image-basic.bb index > >>>> 091f57d..e393a28 > >>>> 100644 > >>>> --- a/meta/recipes-extended/images/core-image-basic.bb > >>>> +++ b/meta/recipes-extended/images/core-image-basic.bb > >>>> @@ -3,9 +3,12 @@ functionality installed." > >>>> > >>>> IMAGE_FEATURES += "splash ssh-server-openssh" > >>>> > >>>> +CORE_IMAGE_EXTRA_INSTALL ?= "" > >>>> > >>>> + > >>> > >>> Not sure if it's my mail client but the above looks slightly mangled; in > >>> any case the above addition shouldn't be needed because > >>> core-image.bbclass already does this. > >> > >> Are you sure it counts? core-image.bbclass is included after this would > >> be evaluated, or does that not matter? > > > > It doesn't matter in most cases, because the value won't actually be > > expanded until later. Values aren't expanded unless you use immediate > > expansion (the := operator) or you d.getVar("SOMEVAR", True) is called > > from python code to return the expanded value. > > Understood, thanks. > > Should I send another patch with that line removed? Yes please. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre