From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Randy Witt <randy.e.witt@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] populate_sdk_ext: Don't put nativesdk and crosssdk items in ext sdk
Date: Mon, 11 Jan 2016 11:19:37 +1300 [thread overview]
Message-ID: <2907273.zL3xaeCVSY@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <d1316b64c02b7e6263fb292f4fc30bff7200a71a.1452194521.git.randy.e.witt@linux.intel.com>
On Thu, 07 Jan 2016 11:24:27 Randy Witt wrote:
> The nativesdk and crosssdk targets were only getting pulled into the
> extensible sdk due to buildtools dependencies being in BB_TASKDEPDATA.
> However the nativesdk and crosssdk targets are not needed for the
> extensible sdk to be used.
>
> This patch therefore removes them since it reduces the size of the
> extensible sdks that include sstate by ~300MB.
>
> Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com>
> ---
> meta/classes/populate_sdk_ext.bbclass | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/meta/classes/populate_sdk_ext.bbclass
> b/meta/classes/populate_sdk_ext.bbclass index 5c99bd0..ef014b8 100644
> --- a/meta/classes/populate_sdk_ext.bbclass
> +++ b/meta/classes/populate_sdk_ext.bbclass
> @@ -173,6 +173,12 @@ python copy_buildsystem () {
> # Filter the locked signatures file to just the sstate tasks we are
> interested in allowed_tasks = ['do_populate_lic', 'do_populate_sysroot',
> 'do_packagedata', 'do_package_write_ipk', 'do_package_write_rpm',
> 'do_package_write_deb', 'do_package_qa', 'do_deploy'] excluded_targets =
> d.getVar('SDK_TARGETS', True)
> +
> + # Since buildtools is included in the sdk, the nativesdk items and
> + # crosssdk end up in the tasks in locked-sigs.inc. However, the
> nativesdk
> + # and crosssdk items aren't needed for the extensible sdk to
> function so
> + # remove them from the list.
> + excluded_targets += 'nativesdk crosssdk'
You need a leading space here to make this work (or alternatively split the
excluded_targets value in the previous patch when you first set it, and add the
items as list items here).
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2016-01-10 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 22:15 [PATCH 0/2] Extensible SDK size reduction Randy Witt
2016-01-06 22:15 ` [PATCH 1/2] copy_buildsystem.py: Allow substring matches for excluded_targets Randy Witt
2016-01-06 22:42 ` Paul Eggleton
2016-01-06 22:15 ` [PATCH 2/2] populate_sdk_ext: Don't put nativesdk and crosssdk items in ext sdk Randy Witt
2016-01-07 19:23 ` [PATCH v2 0/3] Extensible SDK size reduction Randy Witt
2016-01-07 19:24 ` [PATCH 1/3] populate_sdk_ext: Pass excluded_targets as a list to prune_lockedsigs Randy Witt
2016-01-07 19:24 ` [PATCH 2/3] copy_buildsystem.py: Allow substring matches for excluded_targets Randy Witt
2016-01-07 19:24 ` [PATCH 3/3] populate_sdk_ext: Don't put nativesdk and crosssdk items in ext sdk Randy Witt
2016-01-10 22:19 ` Paul Eggleton [this message]
2016-01-11 5:56 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2907273.zL3xaeCVSY@peggleto-mobl.ger.corp.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=randy.e.witt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox