Re: [OE-core] [poky][PATCH v4] Update license file to match current SPDX names and license contents

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Tue, 2020-10-13 at 10:46 +0100, Meh Mbeh Ida Delphine wrote:
> Updated mappings of license fields of meta/conf/licenses.conf to
> match latest SPDX naming.
> Added missing mappings.
> Adde new license files.
> 
> Fixes: [YOCTO #13320]
> 
> Signed-off-by: Meh Mbeh Ida Delphine <idadelm@gmail.com>
> ---
> 
> Changes in V4:
>  * Added license files for AGPL-3.0-or-later, etc
>  * Added new mappings
>  * Updated license content.
> 
> Changes in V3:
>  * Added missing mappings to meta/conf/licenses.conf
> 
> Changes in V2:
>  * Corrected the email subject line.
> 
>  meta/conf/licenses.conf                       |  62 +-
>  meta/files/common-licenses/AGPL-3.0           | 661 ----------------
> --
>  meta/files/common-licenses/AGPL-3.0-only      | 613 ++++++++++++++++
>  meta/files/common-licenses/AGPL-3.0-or-later  | 613 ++++++++++++++++
>  meta/files/common-licenses/GPL-1.0            | 252 -------
>  meta/files/common-licenses/GPL-1.0-only       | 251 +++++++
>  meta/files/common-licenses/GPL-1.0-or-later   | 232 ++++++
>  meta/files/common-licenses/GPL-2.0            | 132 ----
>  meta/files/common-licenses/GPL-2.0-only       | 319 +++++++++
>  meta/files/common-licenses/GPL-2.0-or-later   | 319 +++++++++

Can you describe how you found these files and what you did?

I was expecting a 

"git mv GPL-2.0 GPL-2.0-only"

but the size is different. The size of GPL-2.0-only and GPL-2.0-or-
later is the same which also worries me as those are two different
license wordings.

This patch should only rename the license files that are changed in the
mappings changes. Only related changes should be together in one patch.

A followup patch could add the "or-later" versions and a separate patch
again could also update existing license files to match the upstream
SPDX text (assuming that is what the other change here is).

We need to be careful with changes to the license file contents as some
recipes reference these license files and may need checksum updates. If
the changes are separated out, I have the option of merging the good
patches whilst the others are tweaked but where something is all
together like this, I have no option but to ask for a resend.

>  meta/files/common-licenses/GPL-3.0            | 225 ------
>  meta/files/common-licenses/GPL-3.0-only       | 625
> +++++++++++++++++
>  meta/files/common-licenses/GPL-3.0-or-later   | 625
> +++++++++++++++++
>  meta/files/common-licenses/LGPL-2.0           | 342 ---------
>  meta/files/common-licenses/LGPL-2.0-only      | 446 ++++++++++++
>  meta/files/common-licenses/LGPL-2.0-or-later  | 446 ++++++++++++
>  meta/files/common-licenses/LGPL-2.1           | 176 -----
>  meta/files/common-licenses/LGPL-2.1-only      | 467 +++++++++++++
>  meta/files/common-licenses/LGPL-2.1-or-later  | 468 +++++++++++++
>  meta/files/common-licenses/LGPL-3.0           |  65 --
>  meta/files/common-licenses/LGPL-3.0-only      | 163 +++++
>  meta/files/common-licenses/LGPL-3.0-or-later  | 163 +++++
>  vscode-bitbake-build/bitbake-cookerdaemon.log | 489 +++++++++++++
>  vscode-bitbake-build/bitbake.lock             |   1 +
>  .../cache/bb_persist_data.sqlite3             | Bin 0 -> 12288 bytes
>  vscode-bitbake-build/conf/bblayers.conf       |  12 +
>  vscode-bitbake-build/conf/local.conf          | 277 ++++++++
>  vscode-bitbake-build/conf/templateconf.cfg    |   1 +
>  vscode-bitbake-build/executeBitBakeCmd.sh     |   3 +
>  vscode-bitbake-build/tmp/hosttools/[          |   1 +
>  vscode-bitbake-build/tmp/hosttools/ar         |   1 +
>  vscode-bitbake-build/tmp/hosttools/as         |   1 +
>  vscode-bitbake-build/tmp/hosttools/awk        |   1 +
>  vscode-bitbake-build/tmp/hosttools/basename   |   1 +
[long list of files truncated]


These vscode/bitbake build files should definitely not be included.

Cheers,

Richard