From: richard.purdie@linuxfoundation.org
To: Jiang Lu <lu.jiang@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/4] glib-networking:enable glib-networking build as native package
Date: Wed, 20 Mar 2019 12:03:08 +0000 [thread overview]
Message-ID: <29966a07a2f3bb62205ce0feeeffbac7aa64b57b.camel@linuxfoundation.org> (raw)
In-Reply-To: <20190320093929.28688-4-lu.jiang@windriver.com>
On Wed, 2019-03-20 at 17:39 +0800, Jiang Lu wrote:
> Enable glib-networking build as a native package, for it is depended
> by libsoup.
>
> Signed-off-by: Jiang Lu <lu.jiang@windriver.com>
> ---
> .../glib-networking/glib-networking_2.58.0.bb | 9
> +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/meta/recipes-core/glib-networking/glib-
> networking_2.58.0.bb b/meta/recipes-core/glib-networking/glib-
> networking_2.58.0.bb
> index f3190e1cae..96ba181b71 100644
> --- a/meta/recipes-core/glib-networking/glib-networking_2.58.0.bb
> +++ b/meta/recipes-core/glib-networking/glib-networking_2.58.0.bb
> @@ -29,3 +29,12 @@ FILES_${PN} += "\
> "
> FILES_${PN}-dev += "${libdir}/gio/modules/libgio*.la"
> FILES_${PN}-staticdev += "${libdir}/gio/modules/libgio*.a"
> +
> +# Make sure we compile with ca-certificates support enabled.
> +PACKAGECONFIG_append = " ca-certificates"
This wasn't acceptable in the last patch and still isn't acceptable
now. We don't use _append in recipes like this with PACKAGECONFIG.
> +DEPENDS += "ca-certificates"
> +RDEPENDS_${PN} += "ca-certificates"
This belongs in the PACKAGECONFIG entry.
> +# We need native version for ostree-/flatpak-native.
> +BBCLASSEXTEND = "native"
This belongs in a separate patch.
Cheers,
Richard
next prev parent reply other threads:[~2019-03-20 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 9:39 [v2] libsoup:add a new routine & build as native package Jiang Lu
2019-03-20 9:39 ` [PATCH 1/4] libsoup:add soup_uri_to_string_with_password Jiang Lu
2019-03-20 10:15 ` Burton, Ross
2019-03-20 9:39 ` [PATCH 2/4] libsoup:enable libsoup build as native package Jiang Lu
2019-03-20 10:15 ` Burton, Ross
2019-03-20 9:39 ` [PATCH 3/4] glib-networking:enable glib-networking " Jiang Lu
2019-03-20 10:19 ` Burton, Ross
2019-03-20 11:03 ` Martin Jansa
2019-03-20 12:03 ` richard.purdie [this message]
2019-03-20 9:39 ` [PATCH 4/4] relocatable: add file existence checking in relocatable_native_pcfiles Jiang Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29966a07a2f3bb62205ce0feeeffbac7aa64b57b.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=lu.jiang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox