Re: [OE-core] [PATCH 2/5] libtoml: new recipe

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Adam,

On 12/10/25 12:03 PM, Adam Duskett via lists.openembedded.org wrote:
> [You don't often get email from adam.duskett=amarulasolutions.com@lists.openembedded.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> DNF5 requires libtoml. As such, copy libtoml from
> meta-openembedded to openembedded-core.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>   .../0001-Remove-whitespace-in-operator.patch  | 46 +++++++++++++++++++
>   .../libtoml11/files/run-ptest                 | 12 +++++
>   .../libtoml11/libtoml11_4.4.0.bb              | 40 ++++++++++++++++
>   3 files changed, 98 insertions(+)
>   create mode 100644 meta/recipes-devtools/libtoml11/files/0001-Remove-whitespace-in-operator.patch
>   create mode 100755 meta/recipes-devtools/libtoml11/files/run-ptest
>   create mode 100644 meta/recipes-devtools/libtoml11/libtoml11_4.4.0.bb
> 
> diff --git a/meta/recipes-devtools/libtoml11/files/0001-Remove-whitespace-in-operator.patch b/meta/recipes-devtools/libtoml11/files/0001-Remove-whitespace-in-operator.patch
> new file mode 100644
> index 0000000000..c8c9922d55
> --- /dev/null
> +++ b/meta/recipes-devtools/libtoml11/files/0001-Remove-whitespace-in-operator.patch
> @@ -0,0 +1,46 @@
> +From dee78f822d8a5b985e565e5c1ef42a59557aa8fc Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Fri, 7 Mar 2025 11:35:46 -0800
> +Subject: [PATCH] Remove whitespace in operator""
> +
> +Clang 20+ errors about this whitespace.
> +
> +Fixes
> +include/toml11/impl/../fwd/literal_fwd.hpp:22:26: error: identifier '_toml' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
> +|    22 | ::toml::value operator"" _toml(const char* str, std::size_t len);
> +|       |               ~~~~~~~~~~~^~~~~
> +|       |               operator""_toml
> +
> +Upstream-Status: Submitted [https://github.com/ToruNiina/toml11/pull/285]

This is now merged, so should be a backport. Please don't simply 
rephrase, but also check that the content is the same as merged (or 
simply do a proper backport).

Since you're importing verbatim, a good idea could be to have a 
follow-up patch that changes that.

(Thanks Khem for sending the patch upstream!).

Cheers,
Quentin