From: Mats Karrman <mats.dev.list@gmail.com>
To: ola.redell@gmail.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Append KERNEL_VERSION string to kernel module package names
Date: Tue, 3 Jan 2017 14:56:08 +0100 [thread overview]
Message-ID: <2be3f63c-6e0b-27a9-970e-718ba4afe58c@gmail.com> (raw)
In-Reply-To: <1483450976-22741-2-git-send-email-ola.redell@retotech.se>
Hi,
On 01/03/2017 02:42 PM, ola.redell@gmail.com wrote:
> From: Ola Redell <ola.redell@retotech.se>
>
> The KERNEL_VERSION string is added to kernel module package names in order to
> make the kernel modules for different kernel versions distinct packages instead
> of different versions of the same package. With this change, when a new kernel
> is installed together with its kernel modules (e.g. by upgrade of the packages
> kernel and kernel-modules) using some package manager such as apt-get or rpm,
> the kernel modules for the older kernel will not be removed. This enables a
> fall back to the older kernel if the new one fails.
>
> Signed-off-by: Ola Redell <ola.redell@retotech.se>
> ---
> meta/classes/kernel-module-split.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-module-split.bbclass b/meta/classes/kernel-module-split.bbclass
> index efe1b42..8365448 100644
> --- a/meta/classes/kernel-module-split.bbclass
> +++ b/meta/classes/kernel-module-split.bbclass
> @@ -122,7 +122,7 @@ python split_kernel_module_packages () {
> module_regex = '^(.*)\.k?o$'
>
> module_pattern_prefix = d.getVar('KERNEL_MODULE_PACKAGE_PREFIX')
> - module_pattern = module_pattern_prefix + 'kernel-module-%s'
> + module_pattern = 'kernel-module-%s-' + d.getVar("KERNEL_VERSION", True)
Why did you drop 'module_pattern_prefix'?
>
> postinst = d.getVar('pkg_postinst_modules')
> postrm = d.getVar('pkg_postrm_modules')
next prev parent reply other threads:[~2017-01-03 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 13:42 Kernel module package naming ola.redell
2017-01-03 13:42 ` [PATCH] Append KERNEL_VERSION string to kernel module package names ola.redell
2017-01-03 13:56 ` Mats Karrman [this message]
2017-01-03 14:00 ` Ola Redell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2be3f63c-6e0b-27a9-970e-718ba4afe58c@gmail.com \
--to=mats.dev.list@gmail.com \
--cc=ola.redell@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox