From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>,
Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: RE: [OE-core] [PATCH] librsvg: Only enable the Vala bindings if GObject Introspection is enabled
Date: Wed, 18 Jan 2023 22:22:22 +0000 [thread overview]
Message-ID: <2c4678f5a769445f90b4759a6d6dd259@axis.com> (raw)
In-Reply-To: <20230118172227.28bdb930@booty>
> -----Original Message-----
> From: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Sent: den 18 januari 2023 17:22
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: openembedded-core@lists.openembedded.org; Richard Purdie
> <richard.purdie@linuxfoundation.org>
> Subject: Re: [OE-core] [PATCH] librsvg: Only enable the Vala bindings if
> GObject Introspection is enabled
>
> Hello Peter,
>
> On Wed, 18 Jan 2023 12:27:59 +0100
> "Peter Kjellerstedt" <peter.kjellerstedt@axis.com> wrote:
>
> > This avoids the following error:
> >
> > configure: error: Vala bindings require GObject Introspection
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
>
> A different patch [0] to address the same bug is already in my testing
> branch and is possibly being merged soon on master by Richard. Can you
> please check whether your think your patch is better and let us know?
I had not seen that patch when I sent mine. I think mine is a little better
since it defines and uses a PACKAGECONFIG for the vala support, which should
make it easier for anyone wanting to, e.g., disable the vala support even if
it is enabled by default.
>
> [0] https://git.openembedded.org/openembedded-core-contrib/commit/?h=lucaceresoli/master-next-success&id=e9e761146b52658c06aae150332db666ce2f25a8
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
//Peter
next prev parent reply other threads:[~2023-01-18 22:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 11:27 [PATCH] librsvg: Only enable the Vala bindings if GObject Introspection is enabled Peter Kjellerstedt
2023-01-18 12:13 ` [OE-core] " Jose Quaresma
2023-01-18 14:44 ` Peter Kjellerstedt
2023-01-18 14:55 ` Jose Quaresma
2023-01-18 16:22 ` Luca Ceresoli
2023-01-18 22:22 ` Peter Kjellerstedt [this message]
2023-01-19 9:29 ` Luca Ceresoli
[not found] ` <173BABCA291B8E2A.14781@lists.openembedded.org>
2023-01-19 23:09 ` Luca Ceresoli
2023-01-20 12:53 ` Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c4678f5a769445f90b4759a6d6dd259@axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=luca.ceresoli@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox