Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>,
	 openembedded-core@lists.openembedded.org
Cc: Christopher Larson <chris_larson@mentor.com>
Subject: Re: [PATCH 0/4] Improve logger setup in devtool/recipetool/scriptutils
Date: Tue, 05 Mar 2019 09:36:21 +0000	[thread overview]
Message-ID: <2cb14ca8db048a9e6ce3eb3d6a3974f27e2402aa.camel@linuxfoundation.org> (raw)
In-Reply-To: <2386661.BVp9O4DdDJ@localhost.localdomain>

On Tue, 2019-03-05 at 16:50 +1300, Paul Eggleton wrote:
> On Tuesday, 5 March 2019 10:36:07 AM NZDT Christopher Larson wrote:
> > From: Christopher Larson <chris_larson@mentor.com>
> > 
> > This improves logger setup in devtool and recipetool to send ERRORs
> > to 
> stderr,
> > the way bitbake itself does, and also sends WARNINGs there, as
> > those are
> > essentially out of band as well. This makes it easier to script
> > with devtool
> > and recipetool, as any *real* subcommand output can be more easily
> > captured
> > without having to manually filter out the cruft.
> > 
> > The following changes since commit
> > b11725db2d5549dc45d8ae36fbf94a5c8e342d69:
> > 
> >   xserver-xorg: Fix build errors with clang (2019-03-04 14:26:41
> > +0000)
> > 
> > are available in the Git repository at:
> > 
> >   git@github.com:kergoth/openembedded-core scriptutils-log-
> > improvements
> > 
> > for you to fetch changes up to
> > c4f37568236d2e3d8c40d57399d0b275ad5b7c8b:
> > 
> >   oe.scriptutils: also send WARNING to stderr (2019-03-04 21:31:00
> > +0000)
> > 
> > ----------------------------------------------------------------
> > Christopher Larson (4):
> >       oe.scriptutils: enable color in a more flexible way
> >       oe.scriptutils: add logger_setup_filters
> >       recipetool, devtool: set up the logging filters
> >       oe.scriptutils: also send WARNING to stderr
> > 
> 
> All of these look good to me.
> 
> Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>

Unfortunately there were a couple of issues on the autobuilder in the
devtool selftests with these applied:

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/297

Cheers,

Richard




      reply	other threads:[~2019-03-05  9:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 21:36 [PATCH 0/4] Improve logger setup in devtool/recipetool/scriptutils Christopher Larson
2019-03-04 21:36 ` [PATCH 1/4] oe.scriptutils: enable color in a more flexible way Christopher Larson
2019-03-04 21:36 ` [PATCH 2/4] oe.scriptutils: add logger_setup_filters Christopher Larson
2019-03-04 21:36 ` [PATCH 3/4] recipetool, devtool: set up the logging filters Christopher Larson
2019-03-04 21:36 ` [PATCH 4/4] oe.scriptutils: also send WARNING to stderr Christopher Larson
2019-03-05  3:50 ` [PATCH 0/4] Improve logger setup in devtool/recipetool/scriptutils Paul Eggleton
2019-03-05  9:36   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cb14ca8db048a9e6ce3eb3d6a3974f27e2402aa.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=chris_larson@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox