From: "Khem Raj" <raj.khem@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/2] gcc-target: Ensure buildtools-extended-tarball doesn't use arch=native
Date: Fri, 1 May 2020 09:54:45 -0700 [thread overview]
Message-ID: <2d491ab5-3ac4-aa69-1abb-0696c6122b68@gmail.com> (raw)
In-Reply-To: <20200501164602.1540633-1-richard.purdie@linuxfoundation.org>
On 5/1/20 9:46 AM, Richard Purdie wrote:
> A nativesdk BBCLASSEXTEND was added to gcc-target without realising this
> would pass arch=native through to it for x86-64. This heavily optimises
> gcc output for the host its running on meaning it can't be reused via
> sstate on other machines.
>
> Add class-target overrides here to get the desired behaviour. All
> targets have been covered for completeness.
>
yeah perhaps it should have been --with-arch=generic for non target option,
this looks ok
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> meta/recipes-devtools/gcc/gcc-target.inc | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-target.inc b/meta/recipes-devtools/gcc/gcc-target.inc
> index 8cb432780f5..6263e814971 100644
> --- a/meta/recipes-devtools/gcc/gcc-target.inc
> +++ b/meta/recipes-devtools/gcc/gcc-target.inc
> @@ -15,11 +15,11 @@ EXTRA_OECONF_append_linuxstdbase = " --enable-clocale=gnu"
>
> ARMFPARCHEXT ?= ""
>
> -EXTRA_OECONF_append_armv6 = " --with-arch=armv6${ARMFPARCHEXT}"
> -EXTRA_OECONF_append_armv7a = " --with-arch=armv7-a${ARMFPARCHEXT}"
> -EXTRA_OECONF_append_armv7ve = " --with-arch=armv7ve${ARMFPARCHEXT}"
> -EXTRA_OECONF_append_arc = " --with-cpu=${TUNE_PKGARCH}"
> -EXTRA_OECONF_append_x86-64 = " --with-arch=native"
> +EXTRA_OECONF_append_armv6_class-target = " --with-arch=armv6${ARMFPARCHEXT}"
> +EXTRA_OECONF_append_armv7a_class-target = " --with-arch=armv7-a${ARMFPARCHEXT}"
> +EXTRA_OECONF_append_armv7ve_class-target = " --with-arch=armv7ve${ARMFPARCHEXT}"
> +EXTRA_OECONF_append_arc_class-target = " --with-cpu=${TUNE_PKGARCH}"
> +EXTRA_OECONF_append_x86-64_class-target = " --with-arch=native"
>
> # libcc1 requres gcc_cv_objdump when cross build, but gcc_cv_objdump is
> # set in subdir gcc, so subdir libcc1 can't use it, export it here to
>
>
>
>
next prev parent reply other threads:[~2020-05-01 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 16:46 [PATCH 1/2] gcc-target: Ensure buildtools-extended-tarball doesn't use arch=native Richard Purdie
2020-05-01 16:46 ` [PATCH 2/2] abi_version/staging: Bump versions to force rebuild after sstate corruption Richard Purdie
2020-05-01 16:54 ` Khem Raj [this message]
2020-05-05 10:14 ` [OE-core] [PATCH 1/2] gcc-target: Ensure buildtools-extended-tarball doesn't use arch=native Adrian Bunk
2020-05-05 12:42 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d491ab5-3ac4-aa69-1abb-0696c6122b68@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox