diff for duplicates of <30216.1716477852755796076@lists.openembedded.org> diff --git a/a/1.txt b/N1/1.txt index 9742fec..39dfc46 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ Hi Alex, So problem starts at sstate.bbclass:406 (sstate_install(ss, d)), this should be running after the next for loop (for plain in ss['plaindirs']:). -Having this fixed, jumping to the buildhistory.bbclass:602, find should be out of the loop to give an hard error if it misses. +Having this fixed, jumping to the buildhistory.bbclass:602, find should be out of the loop to give a hard error if it misses. Then inside the for loop, while checking if output folder exists (buildhistory.bbclass:607), this doesnt make sense to me the way it is running: - the comment refers "Make sure the output folder exists...", but we are not creating it if we need, just skipping if doesnt exists. - this folder is being created on do_packagedata (buildhistory.bbclass:396) to write down latest file. diff --git a/a/2.bin b/N1/2.bin index 52986e5..a4d7ded 100644 --- a/a/2.bin +++ b/N1/2.bin @@ -1 +1 @@ -Hi Alex,<br /><br />So problem starts at sstate.bbclass:406 (sstate_install(ss, d)), this should be running after the next for loop (for plain in ss['plaindirs']:).<br /><br />Having this fixed, jumping to the buildhistory.bbclass:602, find should be out of the loop to give an hard error if it misses.<br />Then inside the for loop, while checking if output folder exists (buildhistory.bbclass:607), this doesnt make sense to me the way it is running:<br /> - the comment refers "Make sure the output folder exists...", but we are not creating it if we need, just skipping if doesnt exists.<br /> - this folder is being created on do_packagedata (buildhistory.bbclass:396) to write down latest file.<br /> <br />So before spending more time on this topic i have a few questions to understand a little bit of what should be the strategy to fix this:<br /><br />- If we want to keep files-in-package.txt being created on do_package, shouldnt `buildhistory_list_pkg_files()` (buildhistory.bbclass:600) be responsible to create the folder on buildhistory side?<br />- If we keep `buildhistory_list_pkg_files` being triggered by do_package is there any case of do_package_setscene trigger this? I couldnt find any case to support this option (buildhistory.bbclass:101).<br />- If not we dont need in fact to create files-in-package.txt on do_package, should files-in-package.txt creation be moved to do_packagedata?<br /><br />Thanks,<br /><br />Pedro +Hi Alex,<br /><br />So problem starts at sstate.bbclass:406 (sstate_install(ss, d)), this should be running after the next for loop (for plain in ss['plaindirs']:).<br /><br />Having this fixed, jumping to the buildhistory.bbclass:602, find should be out of the loop to give a hard error if it misses.<br />Then inside the for loop, while checking if output folder exists (buildhistory.bbclass:607), this doesnt make sense to me the way it is running:<br /> - the comment refers "Make sure the output folder exists...", but we are not creating it if we need, just skipping if doesnt exists.<br /> - this folder is being created on do_packagedata (buildhistory.bbclass:396) to write down latest file.<br /> <br />So before spending more time on this topic i have a few questions to understand a little bit of what should be the strategy to fix this:<br /><br />- If we want to keep files-in-package.txt being created on do_package, shouldnt `buildhistory_list_pkg_files()` (buildhistory.bbclass:600) be responsible to create the folder on buildhistory side?<br />- If we keep `buildhistory_list_pkg_files` being triggered by do_package is there any case of do_package_setscene trigger this? I couldnt find any case to support this option (buildhistory.bbclass:101).<br />- If not we dont need in fact to create files-in-package.txt on do_package, should files-in-package.txt creation be moved to do_packagedata?<br /><br />Thanks,<br /><br />Pedro diff --git a/a/2.hdr b/N1/2.hdr index 24bd2b6..6a9de1e 100644 --- a/a/2.hdr +++ b/N1/2.hdr @@ -1,2 +1,2 @@ -Content-Type: text/html; charset="utf-8" +Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable diff --git a/a/content_digest b/N1/content_digest index 8656a0b..07f8034 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0CANNYZj-d-SSYPv-wZF8kfnSvt7i-cG3ec3wotSNETD6-OttyKQ@mail.gmail.com\0" "From\0pmi183@gmail.com\0" "Subject\0Re: [PATCH] buildhistory: Fix do_package race issues\0" - "Date\0Thu, 23 May 2024 08:24:12 -0700\0" + "Date\0Thu, 23 May 2024 08:24:48 -0700\0" "To\0openembedded-core@lists.openembedded.org\0" "\01:1\0" "b\0" @@ -9,7 +9,7 @@ "\n" "So problem starts at sstate.bbclass:406 (sstate_install(ss, d)), this should be running after the next for loop (for plain in ss['plaindirs']:).\n" "\n" - "Having this fixed, jumping to the buildhistory.bbclass:602, find should be out of the loop to give an hard error if it misses.\n" + "Having this fixed, jumping to the buildhistory.bbclass:602, find should be out of the loop to give a hard error if it misses.\n" "Then inside the for loop, while checking if output folder exists (buildhistory.bbclass:607), this doesnt make sense to me the way it is running:\n" "- the comment refers \"Make sure the output folder exists...\", but we are not creating it if we need, just skipping if doesnt exists.\n" "- this folder is being created on do_packagedata (buildhistory.bbclass:396) to write down latest file.\n" @@ -25,6 +25,6 @@ Pedro "\01:2\0" "b\0" - "Hi Alex,<br /><br />So problem starts at sstate.bbclass:406 (sstate_install(ss, d)), this should be running after the next for loop (for plain in ss['plaindirs']:).<br /><br />Having this fixed, jumping to the buildhistory.bbclass:602, find should be out of the loop to give an hard error if it misses.<br />Then inside the for loop, while checking if output folder exists (buildhistory.bbclass:607), this doesnt make sense to me the way it is running:<br /> - the comment refers \"Make sure the output folder exists...\", but we are not creating it if we need, just skipping if doesnt exists.<br /> - this folder is being created on do_packagedata (buildhistory.bbclass:396) to write down latest file.<br /> <br />So before spending more time on this topic i have a few questions to understand a little bit of what should be the strategy to fix this:<br /><br />- If we want to keep files-in-package.txt being created on do_package, shouldnt `buildhistory_list_pkg_files()` (buildhistory.bbclass:600) be responsible to create the folder on buildhistory side?<br />- If we keep `buildhistory_list_pkg_files` being triggered by do_package is there any case of do_package_setscene trigger this? I couldnt find any case to support this option (buildhistory.bbclass:101).<br />- If not we dont need in fact to create files-in-package.txt on do_package, should files-in-package.txt creation be moved to do_packagedata?<br /><br />Thanks,<br /><br />Pedro\r\n" + "Hi Alex,<br /><br />So problem starts at sstate.bbclass:406 (sstate_install(ss, d)), this should be running after the next for loop (for plain in ss['plaindirs']:).<br /><br />Having this fixed, jumping to the buildhistory.bbclass:602, find should be out of the loop to give a hard error if it misses.<br />Then inside the for loop, while checking if output folder exists (buildhistory.bbclass:607), this doesnt make sense to me the way it is running:<br /> - the comment refers \"Make sure the output folder exists...\", but we are not creating it if we need, just skipping if doesnt exists.<br /> - this folder is being created on do_packagedata (buildhistory.bbclass:396) to write down latest file.<br /> <br />So before spending more time on this topic i have a few questions to understand a little bit of what should be the strategy to fix this:<br /><br />- If we want to keep files-in-package.txt being created on do_package, shouldnt `buildhistory_list_pkg_files()` (buildhistory.bbclass:600) be responsible to create the folder on buildhistory side?<br />- If we keep `buildhistory_list_pkg_files` being triggered by do_package is there any case of do_package_setscene trigger this? I couldnt find any case to support this option (buildhistory.bbclass:101).<br />- If not we dont need in fact to create files-in-package.txt on do_package, should files-in-package.txt creation be moved to do_packagedata?<br /><br />Thanks,<br /><br />Pedro\r\n" -4eeadbcc4112c328c1a568351ef690c58e4357733dfc507ff058251be1d3a9bc +d05a8e22128f15e26202c66b361f836f107b5e75f25ebd9e5102bda8a7b562a3
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox