From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Ola x Nilsson <ola.x.nilsson@axis.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 5/9] recipetool: create: support git submodules
Date: Thu, 08 Sep 2016 09:07:52 +1200 [thread overview]
Message-ID: <3071986.dgRiYBiJ1X@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <1e9475f4422447368ffc76229252acbc@XBOX04.axis.com>
Hi Ola,
On Wed, 07 Sep 2016 06:23:15 Ola x Nilsson wrote:
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> > Of Paul Eggleton
> > Sent: den 6 september 2016 12:03
> >
> > Ensure we fetch submodules and set SRC_URI correctly when pointing to a
> > git repository that contains submodules.
> >
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > ---
> >
> > scripts/lib/recipetool/create.py | 12 ++++++++++--
> > 1 file changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/scripts/lib/recipetool/create.py
> > b/scripts/lib/recipetool/create.py index a08352e..7cbd614 100644
> > --- a/scripts/lib/recipetool/create.py
> > +++ b/scripts/lib/recipetool/create.py
> >
> > @@ -399,6 +399,11 @@ def create_recipe(args):
> > if '<html' in f.read(100).lower():
> > logger.error('Fetching "%s" returned a single
> > HTML page - check
> >
> > the URL is correct and functional' % fetchuri)
> >
> > sys.exit(1)
> >
> > + if os.path.exists(os.path.join(srctree, '.gitmodules')) and
> > srcuri.startswith('git://'):
> > + srcuri = 'gitsm://' + srcuri[6:]
> > + logger.info('Fetching submodules...')
> > + bb.process.run('git submodule init', cwd=srctree)
> > + bb.process.run('git submodule update', cwd=srctree)
>
> This is not how the gitsm fetcher does it.
>
> git submodule update --init --recursive
>
> will actually fetch all submodules recursively.
Right, we should indeed be doing that. I've pushed a new commit to the branch.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2016-09-07 21:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 10:03 [PATCH 0/9] devtool / recipetool fixes Paul Eggleton
2016-09-06 10:03 ` [PATCH 1/9] lib/oe/patch: handle non-UTF8 encoding when reading patches Paul Eggleton
2016-09-06 15:50 ` Enrico Scholz
2016-09-06 20:16 ` Paul Eggleton
2016-09-07 10:07 ` Enrico Scholz
2016-09-06 10:03 ` [PATCH 2/9] devtool: update-recipe: support files with subdir= Paul Eggleton
2016-09-06 10:03 ` [PATCH 3/9] recipetool: create: AX_PKG_SWIG should add dependency on swig-native Paul Eggleton
2016-09-06 10:03 ` [PATCH 4/9] recipetool: create: fix mapping python dependencies to python-dbg package Paul Eggleton
2016-09-06 10:03 ` [PATCH 5/9] recipetool: create: support git submodules Paul Eggleton
2016-09-07 6:23 ` Ola x Nilsson
2016-09-07 21:07 ` Paul Eggleton [this message]
2016-09-06 10:03 ` [PATCH 6/9] recipetool: create: add --keep-temp command line option Paul Eggleton
2016-09-06 10:03 ` [PATCH 7/9] recipetool: create: allow license variable handling to be rerun Paul Eggleton
2016-09-06 10:03 ` [PATCH 8/9] recipetool: create: support node.js code outside of npm Paul Eggleton
2016-09-06 10:03 ` [PATCH 9/9] recipetool: create: avoid extra blank lines in output recipe Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3071986.dgRiYBiJ1X@peggleto-mobl.ger.corp.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=ola.x.nilsson@axis.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox