Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Jean-Pierre Geslin" <jarsoper@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] cargo.bbclass: allow to avoid appending PACKAGECONFIG_CONFARGS
Date: Thu, 20 Mar 2025 10:51:05 -0700	[thread overview]
Message-ID: <31837.1742493065363412046@lists.openembedded.org> (raw)
In-Reply-To: <CA+chaQc4kxzLcbFkZswbftUevsjcO4aYDzNVh6hMxj4miv9m1A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

Hello all,

First good catch Martin!
Regarding cargo usage it's better to use feature flag (--feature) as RUSTFLAGS is passed at each compiler invocation (you risk to have a conflict with another feature in other crate dependency compilation and enable it without wanting that).

I'm really sorry if I credited the author incorrectly, I'd made the same fix before looking to see if it had already been proposed.

I think both approaches are respectable, but the revert will keep Rust recipes apart forever, which may not be the most unified IMHO.

[-- Attachment #2: Type: text/html, Size: 680 bytes --]

  reply	other threads:[~2025-03-20 17:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 16:55 [PATCH 1/2] cargo.bbclass: show PACKAGECONFIG_CONFARGS in bbnote martin.jansa
2025-03-20 16:55 ` [PATCH 2/2] cargo.bbclass: allow to avoid appending PACKAGECONFIG_CONFARGS martin.jansa
     [not found] ` <182E912DEB60EF95.20788@lists.openembedded.org>
2025-03-20 16:59   ` [OE-core] " Martin Jansa
2025-03-20 17:06     ` Richard Purdie
     [not found]     ` <182E91CCE4A2B275.19116@lists.openembedded.org>
2025-03-20 17:16       ` Richard Purdie
2025-03-20 17:36         ` Martin Jansa
2025-03-20 17:51           ` Jean-Pierre Geslin [this message]
2025-03-20 18:11           ` Jean-Pierre Geslin
2025-03-24 18:55             ` Alexander Kanavin
2025-03-24 19:30               ` Martin Jansa
2025-03-24 22:29                 ` Richard Purdie
2025-03-31 16:18                 ` akuster808
2025-03-31 16:28                   ` Alexander Kanavin
2025-05-16 15:07                     ` Anton Antonov
2025-05-16 15:55                       ` [OE-core] " Alexander Kanavin
2025-05-16 16:39                         ` Anton Antonov
2025-05-16 17:19                           ` [OE-core] " Alexander Kanavin
2025-05-16 17:43                             ` Marko, Peter
2025-05-16 17:47                             ` Anton Antonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31837.1742493065363412046@lists.openembedded.org \
    --to=jarsoper@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox