From: richard.purdie@linuxfoundation.org
To: Andre McCurdy <armccurdy@gmail.com>
Cc: Joshua Lock <joshua.g.lock@intel.com>,
OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] os-release: fix to install in the expected location
Date: Wed, 05 Sep 2018 09:47:53 +0100 [thread overview]
Message-ID: <31af238ebb7cd5b1be0188a4d705ba93db8a490a.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJ86T=V1rPqM8EYT+y-U2gt0znODtNZ7enaGM5TVBMnPmefgVw@mail.gmail.com>
On Tue, 2018-09-04 at 19:04 -0700, Andre McCurdy wrote:
> On Tue, Sep 4, 2018 at 3:36 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Tue, 2018-09-04 at 13:19 -0700, Andre McCurdy wrote:
> > > On Tue, Sep 4, 2018 at 8:50 AM, Ross Burton <ross.burton@intel.co
> > > m>
> > > wrote:
> > > This probably needs an "rm -f ${D}${sysconfdir}/os-release" too
> > > to
> > > prevent problems if install is run twice as lnr doesn't handle
> > > the
> > > case where the target already exists.
> >
> > Doesn't do_install clean out ${D} each time it reruns though?
>
> Yes, it does. Sometimes it's useful to rerun the run.do_install
> script
> manually though.
We don't support that, I think its reasonable to assume that ${D} is
empty at the start of do_install. To do otherwise would mean changing a
lot of do_install functions for very little gain IMO.
Cheers,
Richard
next prev parent reply other threads:[~2018-09-05 8:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 15:50 [PATCH] os-release: fix to install in the expected location Ross Burton
2018-09-04 20:19 ` Andre McCurdy
2018-09-04 20:46 ` Khem Raj
2018-09-04 22:36 ` Richard Purdie
2018-09-05 2:04 ` Andre McCurdy
2018-09-05 8:47 ` richard.purdie [this message]
2018-09-05 15:56 ` Andre McCurdy
2018-09-05 10:31 ` Martin Jansa
2018-09-04 23:00 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31af238ebb7cd5b1be0188a4d705ba93db8a490a.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=armccurdy@gmail.com \
--cc=joshua.g.lock@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox